Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlantUML diagrams always "update" on updating test sites #1130

Closed
yash-chowdhary opened this issue Mar 17, 2020 · 1 comment · Fixed by #1993
Closed

PlantUML diagrams always "update" on updating test sites #1130

yash-chowdhary opened this issue Mar 17, 2020 · 1 comment · Fixed by #1993

Comments

@yash-chowdhary
Copy link
Contributor

yash-chowdhary commented Mar 17, 2020

Tell us about your environment

  • MarkBind Version: 2.12.0

What did you do? Please include the actual source code causing the issue.

  • Branched off of master
  • Ran npm run updatetest

What did you expect to happen?
Since it's a newly created branch w/o any changes, nothing should be affected.

What actually happened? Please include the actual, raw output.
All PUML diagrams in test/functional/test_site/expected/diagrams are "updated".
Specifically, the size of the .png files is affected -

  • before running updatetest (on master branch) -

    image

  • after running updatetest (on the newly created branch) -

    image

@alyip98
Copy link
Contributor

alyip98 commented Mar 21, 2020

The reason this happens is because PlantUML includes the language of the OS running it in the metadata of the generated PNG. The difference is due to the files being generated with en-US and en-SG (I forgot which is which).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants