Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopNav: Drop-downs are not shown when using themes #1444

Closed
damithc opened this issue Jan 14, 2021 · 2 comments · Fixed by #1451
Closed

TopNav: Drop-downs are not shown when using themes #1444

damithc opened this issue Jan 14, 2021 · 2 comments · Fixed by #1451

Comments

@damithc
Copy link
Contributor

damithc commented Jan 14, 2021

Without a theme:
image

With a theme:
image

@raysonkoh
Copy link
Contributor

I think there was some changes made to bootswatch at this specific commit, the relevant changes which I think caused this issue is shown below.

image,

Upon inspection using the dev tools, I noticed that the same changes were being reflected in the bootstrap.css.

image

It is showing that the bootswatch version in the released markbind is v4.5.3.

image

We can either downgrade to v4.5.0, before that commit or work on a fix for this. @ang-zeyu any thoughts on this?

@ang-zeyu
Copy link
Contributor

thanks for investigating it! @raysonkoh

since it looks simple and generic, let's fix it 🙂

fyi: there are a few theme-specific issues (especially with the searchbar) we have decided not to fix previously, as its too much work working on and tracking 15 separate bootswatch themes.
The solution in the long run would be to move to our own style system #903, shifting the burden of customization to the user

But likely something for v4.0 maybe =P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants