Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some images in User Guide not working #1710

Closed
ong6 opened this issue Jan 13, 2022 · 1 comment · Fixed by #1711
Closed

Some images in User Guide not working #1710

ong6 opened this issue Jan 13, 2022 · 1 comment · Fixed by #1711
Labels
a-Documentation 📝 c.Bug 🐛

Comments

@ong6
Copy link
Contributor

ong6 commented Jan 13, 2022

Tell us about your environment

Viewing from Google Chrome

  • MarkBind Version:
    N/A

What did you do? Please include the actual source code causing the issue.

Was reading more about plugins when i noticed that the sample images when plugins are added are all not present.

Example image from using plugins page:
image

What did you expect to happen?

Images should load properly

What actually happened? Please include the actual, raw output.
N/A
@tlylt
Copy link
Contributor

tlylt commented Jan 13, 2022

Can confirm this behavior.
When checking out the image files that the broken images are referring to, it seems like the images themselves are broken:
image

It seems like the problem is introduced in this commit for PR: Wrap fenced code blocks on-demand(#1668)

@ong6 ong6 mentioned this issue Jan 13, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-Documentation 📝 c.Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix missing images from Plugin page of user guide ong6/markbind
3 participants
@ong6 @tlylt @jonahtanjz