Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: Rewrite the positioning logic of popupMixins.js #397

Closed
yamgent opened this issue Jul 31, 2018 · 1 comment
Closed

Tooltip: Rewrite the positioning logic of popupMixins.js #397

yamgent opened this issue Jul 31, 2018 · 1 comment

Comments

@yamgent
Copy link
Member

yamgent commented Jul 31, 2018

Tell us about your environment

  • MarkBind Version: The version after 1.10.0

What did you do? Please include the actual source code causing the issue.

As specified in issue #338, there was a tooltip positioning issue.

However, it was difficult to disentangle the logic inside popupMixins.js because it is spaghetti code, so it was hard to explain the logic behind the calculation of the tooltip position.

A temporary fix was done in PR MarkBind/vue-strap#87. It uses the mouse cursor position to fix the issue. However, we lose the original aesthetic of the tooltip provided by Bootstrap (the arrows in tooltip is gone + the placement attribute no longer matters now).

A more permanent solution would be to either rewrite popupMixins.js, or further experiment with Bootstrap-Vue's tooltip to see how we can modify it to suit MarkBind's needs.

@ang-zeyu
Copy link
Contributor

Closed by #1033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants