Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce replication of constants #597

Closed
marvinchin opened this issue Jan 19, 2019 · 1 comment · Fixed by #949
Closed

Reduce replication of constants #597

marvinchin opened this issue Jan 19, 2019 · 1 comment · Fixed by #949

Comments

@marvinchin
Copy link
Contributor

Tell us about your environment

  • MarkBind Version:
    MarkBind v1.16.1

What did you expect to happen?
Constants can be defined in a single file and reused where needed

What actually happened? Please include the actual, raw output.
Some constants are reused across Site.js, Page.js, and cliUtil.js (e.g. LAYOUT_FOLDER_PATH)

@nicholaschuayunzhi
Copy link
Contributor

For different sub logic it has been suggested in #698 (comment) to have file naming structure of {{main module}}.{{sub module}}.js

Additionally it is suggested that constants should be placed in constants.js #698 (comment)

@luyangkenneth luyangkenneth added this to Inbox in Developer Experience Opportunities via automation Apr 4, 2019
@luyangkenneth luyangkenneth moved this from Inbox / Uncategorized to Goal: Reduce technical debt and development friction in Developer Experience Opportunities Apr 4, 2019
Developer Experience Opportunities automation moved this from Goal: Reduce technical debt to Closed Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants