Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code comments to major source files #602

Closed
jamos-tay opened this issue Jan 19, 2019 · 1 comment
Closed

Add code comments to major source files #602

jamos-tay opened this issue Jan 19, 2019 · 1 comment

Comments

@jamos-tay
Copy link
Contributor

Most of the source code is very sparse in comments, with many complex functions left undocumented. This makes it difficult for developers who are new to the project to understand it.

In particular, the Page.js, Site.js, parser.js files which encapsulate a lot of MarkBind's functionality could be reviewed and comments added.

Currently we don't require PRs to include comments. It might be helpful to encourage using simple comments during reviews.

@luyangkenneth luyangkenneth added this to Inbox in Developer Experience Opportunities via automation Apr 4, 2019
@luyangkenneth luyangkenneth moved this from Inbox / Uncategorized to Goal: Encourage open-source contributions in Developer Experience Opportunities Apr 4, 2019
@luyangkenneth luyangkenneth moved this from Goal: Encourage open-source contributions to Goal: Reduce technical debt in Developer Experience Opportunities Apr 4, 2019
@luyangkenneth luyangkenneth moved this from Goal: Reduce technical debt to Goal: Encourage open-source contributions in Developer Experience Opportunities Apr 4, 2019
@luyangkenneth luyangkenneth moved this from Goal: Encourage open-source contributions + Improve contributor experience to Goal: Reduce technical debt in Developer Experience Opportunities Apr 10, 2019
@ang-zeyu
Copy link
Contributor

quite a few now; closing as its a continuing work :-)

Developer Experience Opportunities automation moved this from Goal: Reduce technical debt to Closed Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants