-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give easy ways to add different types of horizontal lines #897
Comments
Hi @damithc, is this issue still relevant? If so I would like to have a go at this. |
Yes @tlylt |
Hi @damithc, I think supporting different types of horizontal lines should be doable.
Text Before
===
Text After^^^ As for the dotted line, I am not sure if using Some story text
...
Some story text afterward I am not sure if the use of '...' will be confusing for writers (if my assumption above is valid). ps: if any of the active devs have any thoughts on this please feel free to comment as well :) |
@tlylt I'm wondering if we should go for something like
But I'm not sure if this complicates the implementation too much. What do others think? |
For the current implementation of horizontal lines by Markdown-it(which follows the CommonMark spec), all following cases will result in a I feel that on top of implementation details, perhaps we should stick with the existing standard practices? So when a divider symbol is used, it should work as long as it is
That's why I am thinking if we can use a separate symbol to translate to a styled
Also just a note, the existing hr rule is applied to Edit: some good examples on thematic-break in the CommonMark Spec here |
Sounds good.
Something like
There is a legit reason to use un-indented |
I think reusing the
How about loosing the
I think another concern is also how / whether we should allow specifying how "thick" Currently thinking |
Sounds good. Any possibility of throwing in color options as well (using the bootstrap default colors |
Current:
-----------------
results in a<hr>
Suggested: we can also support other types of lines
e.g.,
=============
-> double line............
-> dotted lineThe text was updated successfully, but these errors were encountered: