Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support live-preview for .puml files #913

Closed
damithc opened this issue Jun 28, 2019 · 6 comments · Fixed by #955 or #974
Closed

Support live-preview for .puml files #913

damithc opened this issue Jun 28, 2019 · 6 comments · Fixed by #955 or #974

Comments

@damithc
Copy link
Contributor

damithc commented Jun 28, 2019

Suggestion: capture changes to .puml files in the live preview

@damithc
Copy link
Contributor Author

damithc commented Jan 10, 2020

This doesn't seem to work in v2.9.0
Specifically, for puml files

@damithc damithc reopened this Jan 10, 2020
@damithc
Copy link
Contributor Author

damithc commented Jan 10, 2020

@ang-zeyu can have a look?

@damithc
Copy link
Contributor Author

damithc commented Jan 10, 2020

Some further observations:
Lets say a.md has a diagram specified in d.puml.

  • modify d.puml; the change is not visible in the live-preview of a.md
  • do some further change to a.md; the change to the diagram becomes visible in the live preview.

@ang-zeyu
Copy link
Contributor

Lets say a.md has a diagram specified in d.puml.

  • modify d.puml; the change is not visible in the live-preview of a.md
  • do some further change to a.md; the change to the diagram becomes visible in the live preview.

Hmm, tried this use case and the test site which has plantumls inside <include />'s again, but I can't reproduce it

What is the src specified as?

@damithc
Copy link
Contributor Author

damithc commented Jan 10, 2020

What is the src specified as?

Here's the file https://raw.githubusercontent.com/nus-cs2103/website-base/master/admin/gradeBreakdown.md

The specific line is inside a nunjucks macro, but I tried it outside a macro with the same result.

@ang-zeyu
Copy link
Contributor

Thanks!

Found the likely issue, relative paths were handled from the root site folder rather than the file's original location.
It'll only work currently if the file(s) are already in the root folder ( such as in the test site )

Will get a fix out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants