timeout not used if specified in cr_build_yaml()

[MarkEdmondson1234]

This should work?

cr_build_yaml(steps, 
              timeout = 3600,
              options = list(machineType = 'N1_HIGHCPU_8'))

[dmoimpact]

Unfortunately the output ignores the settings at the current moment:

[MarkEdmondson1234]

@dmoimpact what code are you using to try to generate the build?

[MarkEdmondson1234]

This seems to work:

cr_build(
  cr_build_yaml(steps = cr_buildstep_docker("my-image"), 
                options = list(machineType = "N1_HIGHCPU_8"))
)

[dmoimpact]

scheduleR <- cr_build_yaml(
  steps = c(
    cr_buildstep(...
)))

my_build <- cr_build_make(scheduleR)
schedule_build <- cr_build(my_build,timeout = "3600s",options = list(machineType ='N1_HIGHCPU_8'))

(I tried with, and without "" in the seconds.)

[MarkEdmondson1234]

You can specify the option at build time or when you make the yaml, but they both seem to work for me:

cr_build(
  cr_build_yaml(steps = cr_buildstep_docker("my-image")), 
  options = list(machineType = "N1_HIGHCPU_8")
)

[MarkEdmondson1234]

Ok I think its about timeout not the option?

In which case yes it currently doesn't respect the timeout if its in cr_build_yaml(), only if its in cr_build_make() or cr_build():

cr_build_make(cr_build_yaml(
                    cr_buildstep_docker("my-image"), 
                    timeout = 500,
                    options = list(machineType = 'N1_HIGHCPU_8')), 
               timeout = 777)
#==CloudBuildObject==
#timeout:  777s 
#steps:
#- name: gcr.io/cloud-builders/docker
#  args:
# ...

[MarkEdmondson1234]

Should be fixed in latest version:

cr_build_make(cr_build_yaml(cr_buildstep_docker("my-image"), 
              timeout = 500,
              options = list(machineType = 'N1_HIGHCPU_8')))
# ==CloudBuildObject==
# timeout:  500s 
# steps:

[dmoimpact]

Great, I will try it our. Thanks!