Composer page name is lowercase #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merge it, but could you remove changes of gitignore. It's not about this PR. I commit it later. Btw, 👍 for lowercase |
|
👍 |
|
Things like '/.idea' should go to your personal global gitignore, not repo. |
|
I've removed non-relevant .gitignore change. Thank you for feedback :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was adding
Markette/GopayApipackage to Packagist, I've get error:"The package name Markette/GopayApi is invalid, it should not contain uppercase characters. We suggest using markette/gopay-api instead."
Anyway, see README.md: https://github.com/Markette/Gopay/blob/master/README.md#instalace
There is also
composer require markette/gopay.So I've changed it in the composer.json.