Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recurrent payments #42

Closed
wants to merge 1 commit into from
Closed

Conversation

pabyska
Copy link

@pabyska pabyska commented Jun 29, 2015

No description provided.

@vojtech-dobes
Copy link
Contributor

Thanks for contribution!

I have some notes - primarily it quite pollutes Service. It's bit god-like already, which isn't good, and this makes it worse. It would nicer to implement this with better architecture. What about maybe changing Payment to interface (introducing IPayment to avoid BC break). There could be then RecurringPayment which would implement setting and using all those extra parameters.

@f3l1x
Copy link
Member

f3l1x commented Jun 29, 2015

Thanks.

According to Vojta. I would like to split Service, to more specific services.

PayService, RecurrentService and also specific entities. Payment and RecurrentPayment.

How about that?

@f3l1x
Copy link
Member

f3l1x commented Oct 13, 2015

@f3l1x f3l1x closed this Oct 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants