-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0.x] Emergency parser for multiple serial ports #10524
[2.0.x] Emergency parser for multiple serial ports #10524
Conversation
20b2024
to
dd5b6f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach, that's why I chose it for my LPC1768 PR, but not doing much AVR development I was worried about adding overhead to the UART ISR if I generalised the implementation, you know better than me that it's OK.
emergent_state
is an little odd for the state variable.
It could all be moved to
Maybe I watched too many medical dramas. I'll change it to |
dd5b6f8
to
da4c8e2
Compare
Would you be ok with adding a single character realtime command, such as 0x18 (Ctrl-X), to reset the mcu.. this isn't at all because I wouldn't have to cross the room to reset my Re-ARM to flash |
|
For the ARM MCUs its just
|
An infinite loop will reset if the watchdog is on. Or, a jump to address 0x00 will do it. |
Followup to #10516
Make sure the emergency parser can track state for multiple serial inputs.
This may need to be augmented with an additional
emergent_state
for each serial device, attached to whichever object is most closely associated with the serial input instance, whether it's the input ring buffer, the static class, or whatever.Build tested for AVR, DUE, and LPC1768.