[BUG] (mks Robin compiling error cs_pin not declared) #15439

fizga · 2019-10-01T12:33:49Z

i try to build marlin in Visual studio en have this error :

In file included from Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/HAL.h:36:0,
from Marlin\src\feature\touch../../inc/../HAL/HAL.h:26,
from Marlin\src\feature\touch../../inc/MarlinConfig.h:30,
from Marlin\src\feature\touch\xpt2046.cpp:25:
Marlin\src\feature\touch\xpt2046.cpp: In static member function 'static void XPT2046::init()':
Marlin\src\feature\touch\xpt2046.cpp:40:26: error: 'CS_PIN' was not declared in this scope
#define TOUCH_CS_PIN CS_PIN
^
Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/fastio.h:37:53: note: in definition of macro '_SET_MODE'
#define _SET_MODE(IO,M) gpio_set_mode(PIN_MAP[IO].gpio_device, PIN_MAP[IO].gpio_bit, M)
^~
Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/fastio.h:41:35: note: in expansion of macro '_SET_OUTPUT'
#define OUT_WRITE(IO,V) do{ _SET_OUTPUT(IO); WRITE(IO,V); }while(0)
^~~~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:50:3: note: in expansion of macro 'OUT_WRITE'
OUT_WRITE(TOUCH_CS_PIN, HIGH);
^~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:50:13: note: in expansion of macro 'TOUCH_CS_PIN'
OUT_WRITE(TOUCH_CS_PIN, HIGH);
^~~~~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:40:26: note: suggested alternative: 'SS_PIN'
#define TOUCH_CS_PIN CS_PIN
^
Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/fastio.h:37:53: note: in definition of macro '_SET_MODE'
#define _SET_MODE(IO,M) gpio_set_mode(PIN_MAP[IO].gpio_device, PIN_MAP[IO].gpio_bit, M)
^~
Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/fastio.h:41:35: note: in expansion of macro '_SET_OUTPUT'
#define OUT_WRITE(IO,V) do{ _SET_OUTPUT(IO); WRITE(IO,V); }while(0)
^~~~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:50:3: note: in expansion of macro 'OUT_WRITE'
OUT_WRITE(TOUCH_CS_PIN, HIGH);
^~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:50:13: note: in expansion of macro 'TOUCH_CS_PIN'
OUT_WRITE(TOUCH_CS_PIN, HIGH);
^~~~~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp: In static member function 'static uint16_t XPT2046::getInTouch(XPTCoordinate)':
Marlin\src\feature\touch\xpt2046.cpp:40:26: error: 'CS_PIN' was not declared in this scope
#define TOUCH_CS_PIN CS_PIN
^
Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/fastio.h:37:53: note: in definition of macro '_SET_MODE'
#define _SET_MODE(IO,M) gpio_set_mode(PIN_MAP[IO].gpio_device, PIN_MAP[IO].gpio_bit, M)
^~
Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/fastio.h:41:35: note: in expansion of macro '_SET_OUTPUT'
#define OUT_WRITE(IO,V) do{ _SET_OUTPUT(IO); WRITE(IO,V); }while(0)
^~~~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:103:3: note: in expansion of macro 'OUT_WRITE'
OUT_WRITE(TOUCH_CS_PIN, LOW);
^~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:103:13: note: in expansion of macro 'TOUCH_CS_PIN'
OUT_WRITE(TOUCH_CS_PIN, LOW);
^~~~~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:40:26: note: suggested alternative: 'SS_PIN'
#define TOUCH_CS_PIN CS_PIN
^
Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/fastio.h:37:53: note: in definition of macro '_SET_MODE'
#define _SET_MODE(IO,M) gpio_set_mode(PIN_MAP[IO].gpio_device, PIN_MAP[IO].gpio_bit, M)
^~
Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/fastio.h:41:35: note: in expansion of macro '_SET_OUTPUT'
#define OUT_WRITE(IO,V) do{ _SET_OUTPUT(IO); WRITE(IO,V); }while(0)
^~~~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:103:3: note: in expansion of macro 'OUT_WRITE'
OUT_WRITE(TOUCH_CS_PIN, LOW);
^~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:103:13: note: in expansion of macro 'TOUCH_CS_PIN'
OUT_WRITE(TOUCH_CS_PIN, LOW);
^~~~~~~~~~~~
In file included from Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/HAL.h:36:0,
from Marlin\src\feature\touch../../inc/../HAL/HAL.h:26,
from Marlin\src\feature\touch../../inc/MarlinConfig.h:30,
from Marlin\src\feature\touch\xpt2046.cpp:25:
Marlin\src\feature\touch\xpt2046.cpp:40:26: error: 'CS_PIN' was not declared in this scope
#define TOUCH_CS_PIN CS_PIN
^
Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/fastio.h:33:40: note: in definition of macro 'WRITE'
#define WRITE(IO,V) (PIN_MAP[IO].gpio_device->regs->BSRR = (1U << PIN_MAP[IO].gpio_bit) << ((V) ? 0 : 16))
^~
Marlin\src\feature\touch\xpt2046.cpp:123:9: note: in expansion of macro 'TOUCH_CS_PIN'
WRITE(TOUCH_CS_PIN, HIGH);
^~~~~~~~~~~~
Marlin\src\feature\touch\xpt2046.cpp:40:26: note: suggested alternative: 'SS_PIN'
#define TOUCH_CS_PIN CS_PIN
^
Marlin\src\feature\touch../../inc/../HAL/./HAL_STM32F1/fastio.h:33:40: note: in definition of macro 'WRITE'
#define WRITE(IO,V) (PIN_MAP[IO].gpio_device->regs->BSRR = (1U << PIN_MAP[IO].gpio_bit) << ((V) ? 0 : 16))
^~
Marlin\src\feature\touch\xpt2046.cpp:123:9: note: in expansion of macro 'TOUCH_CS_PIN'
WRITE(TOUCH_CS_PIN, HIGH);
^~~~~~~~~~~~
*** [.pio\build\mks_robin\src\src\feature\touch\xpt2046.cpp.o] Error 1

I can not find the solution !
here the file i use
Marlin-2.0.x.zip

tpruvot · 2019-10-02T11:54:09Z

right, maybe my fault... need #define TOUCH_CS_PIN PB1

tpruvot · 2019-10-02T12:03:34Z

made the PR #15445

fizga · 2019-10-03T14:03:38Z

Thanks for the answer !
I made the change! Now build success but when i launch the robin motherboard the tft indicate complete And he stays like that
The tft is mks V2

tpruvot · 2019-10-04T11:51:16Z

According to the schematic https://github.com/makerbase-mks/MKS-Robin/blob/master/MKS%20Robin/Hardware/MKS%20Robin%20V2.3_001%20SCH.pdf

It might be required to manually set software SPI2 pins too, in the touchscreen section...

#define TOUCH_SCK_PIN  PB13
#define TOUCH_MISO_PIN PB14
#define TOUCH_MOSI_PIN PB15

If you could test and confirm....

what do you mean by the "tft indicates complete" ? could you do a picture ?

fizga · 2019-10-04T12:49:26Z

I made the changes in the file xpt2046.cpp but unfortunately for the same result.
here is an picture of the screen

I tried another version of MARLIN on this link
https://github.com/makerbase-mks/MKS-Robin/tree/master/MKS%20Robin/firmware
this works well I can activate almost all the options.
but when I turn on the BLtouch line or the line #define NUM_SERVOS 1
the screen remains black

tpruvot · 2019-10-04T17:13:54Z

right, look like this "Complete" is displayed by the bootloader, doesnt look like Marlin code. Maybe after the SD upgrade is done... Did you try to reboot the board then, with and without the SD inserted ?

fizga · 2019-10-04T17:37:49Z

I just tried but it's the same thing.
can be a problem on the TFT library ??
I think it comes from the code because when I test the code mentioned above it works well except for the BLTOUCH.

tpruvot · 2019-10-04T18:36:27Z

Well the code you linked is not current marlin source code... can be anything... hard to compare both. But I seen weird pin definitions, like the "Custom SPI" section, affected to some pins required for the internal SD (SDIO)

fizga · 2019-10-04T19:39:16Z

OK, but I'm not a coding expert! I would like the original MARLIN to work but it is not! the display shows nothing! I browse the different files, I can not find the solution!
the blue led of the processor constantly flashes as if I were infinite loop

megamih · 2019-10-05T22:14:43Z

the code you linked is not current marlin source code
Hi @tpruvot,

I believe this code came from https://github.com/jmz52/Marlin/tree/MKS-Robin-Touch-POC
And I can confirm, that MKS Robin screen stopped to work for me June - July this year. I believe it is related to generalizing MKS Robin 320x240 color display into FSMC display (MKS Robin, Alfawise U20, JGAurora A5S, A1, etc.) (somewhere nearby commit bc58e67 from 2019-07-30 10:00).
btw. If there is a way to gather some useful logs etc. - could you please point me to proper procedure?

Best regards,
Alex

fizga · 2019-10-06T08:01:52Z

I also think that it comes from that
do you have the latest version that worked for you. I could try it with the bltouch

tpruvot · 2019-10-06T15:26:09Z

made a PR #15474 to fix the wrong pin definitions, could be related...

tpruvot · 2019-10-06T16:01:18Z

I ordered the board, but will take some weeks to get it... Also i seen the Robin2 wiring seems very different on schematics... and not yet in Marlin sources

fizga · 2019-10-06T17:50:34Z

Of course robin 2.4 is different from robin2
The processor is a 32f4xx instead of 32f1xx
Hope you find the solution
Thanks

tpruvot · 2019-10-06T17:58:57Z

yep, noticed that in their sources, after... for the F4 (robin2) had some confusion with "v2.4" first...

megamih · 2019-10-06T20:43:04Z

Hi @tpruvot,
First of all, thank you very much for your time and effort.
I pulled latest Marlin bugfix-2.0.x (fc6a093) and locally merged PR #15474 - but still same story :( 'Complete' is shown on the screen after re-flash.

tpruvot · 2019-10-07T15:06:46Z

ok, no other info over usb/serial during the boot ? Which size/model is your TFT ?

fizga · 2019-10-07T15:21:58Z

My tft is mks robin tft_V2.0 3.2 inch
Never test upload firmware by usb! Will try this!

fizga · 2019-10-08T10:04:30Z

ok when i try to upload have this

maybe I did something wrong !??

tpruvot · 2019-10-09T14:58:15Z

You are using the file Robin.bin for the SD update, right?

fizga · 2019-10-09T15:07:08Z

Yes ! I m using Robin.bin

boelle · 2019-10-12T12:39:44Z

@fizga issue still there?

fizga · 2019-10-12T12:46:10Z

yes still not solved

tpruvot · 2019-10-12T13:05:18Z

Title and problem description is no more related to your issue... maybe close this one and reopen a new one.. with current status

boelle · 2019-10-12T13:08:05Z

suggestions for a better title would be? i can edit the title so it better shows about the problem

but yes i agree to hit close an create a new issue with correct title and status

fizga · 2019-10-12T13:17:05Z

Ok i will close this and open a new one !

github-actions · 2020-07-04T10:03:23Z

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

fizga closed this as completed Oct 12, 2019

Kokorone mentioned this issue Apr 22, 2020

Printer Halted! makerbase-mks/Mks-Robin-Nano-Marlin2.0-Firmware#7

Closed

github-actions bot locked and limited conversation to collaborators Jul 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] (mks Robin compiling error cs_pin not declared) #15439

[BUG] (mks Robin compiling error cs_pin not declared) #15439

fizga commented Oct 1, 2019

tpruvot commented Oct 2, 2019

tpruvot commented Oct 2, 2019

fizga commented Oct 3, 2019 •

edited

Loading

tpruvot commented Oct 4, 2019 •

edited

Loading

fizga commented Oct 4, 2019 •

edited

Loading

tpruvot commented Oct 4, 2019

fizga commented Oct 4, 2019

tpruvot commented Oct 4, 2019 •

edited

Loading

fizga commented Oct 4, 2019 •

edited

Loading

megamih commented Oct 5, 2019

fizga commented Oct 6, 2019

tpruvot commented Oct 6, 2019

tpruvot commented Oct 6, 2019

fizga commented Oct 6, 2019

tpruvot commented Oct 6, 2019

megamih commented Oct 6, 2019

tpruvot commented Oct 7, 2019

fizga commented Oct 7, 2019

fizga commented Oct 8, 2019

tpruvot commented Oct 9, 2019

fizga commented Oct 9, 2019

boelle commented Oct 12, 2019

fizga commented Oct 12, 2019

tpruvot commented Oct 12, 2019 •

edited

Loading

boelle commented Oct 12, 2019

fizga commented Oct 12, 2019

github-actions bot commented Jul 4, 2020

[BUG] (mks Robin compiling error cs_pin not declared) #15439

[BUG] (mks Robin compiling error cs_pin not declared) #15439

Comments

fizga commented Oct 1, 2019

tpruvot commented Oct 2, 2019

tpruvot commented Oct 2, 2019

fizga commented Oct 3, 2019 • edited Loading

tpruvot commented Oct 4, 2019 • edited Loading

fizga commented Oct 4, 2019 • edited Loading

tpruvot commented Oct 4, 2019

fizga commented Oct 4, 2019

tpruvot commented Oct 4, 2019 • edited Loading

fizga commented Oct 4, 2019 • edited Loading

megamih commented Oct 5, 2019

fizga commented Oct 6, 2019

tpruvot commented Oct 6, 2019

tpruvot commented Oct 6, 2019

fizga commented Oct 6, 2019

tpruvot commented Oct 6, 2019

megamih commented Oct 6, 2019

tpruvot commented Oct 7, 2019

fizga commented Oct 7, 2019

fizga commented Oct 8, 2019

tpruvot commented Oct 9, 2019

fizga commented Oct 9, 2019

boelle commented Oct 12, 2019

fizga commented Oct 12, 2019

tpruvot commented Oct 12, 2019 • edited Loading

boelle commented Oct 12, 2019

fizga commented Oct 12, 2019

github-actions bot commented Jul 4, 2020

fizga commented Oct 3, 2019 •

edited

Loading

tpruvot commented Oct 4, 2019 •

edited

Loading

fizga commented Oct 4, 2019 •

edited

Loading

tpruvot commented Oct 4, 2019 •

edited

Loading

fizga commented Oct 4, 2019 •

edited

Loading

tpruvot commented Oct 12, 2019 •

edited

Loading