-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements and fixes to Lulzbot UI #15490
Improvements and fixes to Lulzbot UI #15490
Conversation
marcio-ao
commented
Oct 8, 2019
- Fix for incorrect tags on background items
- Improvements to Bio printer UI
- Theme colors are now selected in HSL space.
- Fix for incorrect tags on background items - Improvements to Bio printer UI - Theme colors are now selected in HSL space.
This seems like it should not work: #define CLCD_MOD_RESET LCD_PINS_ENABLE
#define CLCD_SPI_CS LCD_PINS_D4 …because these pins are not defined by any of the pins files unless a particular display is selected, and I don't see any special cases for these added to the pins files for the Lulzbot Touch UI. As a result, it looks like only the |
It appears that the
|
Maybe it is this disagreement between
|
Perhaps I need more settings to get a proper build. Here is what I added to
…and I also had to add to #ifndef SPI_SPEED
#define SPI_SPEED SPI_FULL_SPEED
#endif What else is needed to get a successful test build? |
I've added the non-working test for |
On certain boards, I put in a special case in the pins files:
This only happens on the Archim 2 and the Rambo boards which Lulzbot uses. That said, running Travis with |
I'll look into the other issues and see if I can find fixes. |
This was an error when compiling without |
- It is not possible to index into a constexpr array if the index is unknown at compile-time. - Making an const array would require wasting bytes in PROGMEM.