-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Estimate Remaining Time (graphical display) #15497
Estimate Remaining Time (graphical display) #15497
Conversation
5cad9f1
to
31f3b67
Compare
e212008
to
6428bec
Compare
I have a strange issue with LCD and seems that this PR not related to them. When I print from SD file without M73 commands in it - LCD updates as usual, once per second: https://youtu.be/6oVtPs9nY8I Problem is that later LCD freezes - probably due to very high mcu load from lcd calculation and drawing. I have no idea how this matters. |
77b2649
to
547b134
Compare
I made some investigation about "quick LCD updating". It's not relevant to this PR or M73 command at all, instead it occurs after any M117 command. Probably, we must create a bug. |
The solution is to comment out the |
a652dab
to
41e1443
Compare
88d4d10
to
8c2e8cc
Compare
8c2e8cc
to
9e121ef
Compare
I think there is an issue around this line: Marlin/Marlin/src/libs/numtostr.cpp Line 206 in b20d5a7
|
Here is fixup: LinFor@a732649 |
This is currently in draft so I can do more testing on real hardware.
Description
All of these is done only for DOGM displays, but possible for another ones (but I hasn't somthing another hardware for testing).
Benefits
Ability to estimate time to print completion.
Ability to more precise estimate print progress for long-running prints.
Demo
Related Issues
#12123, #8515, #2181