-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix G2/G3 rounding error #15507
Fix G2/G3 rounding error #15507
Conversation
Fix error introduced in #15204 Fix problem when rounding of arc radius by slicer made arc geometrically impossible.
Good fix, thanks! |
DUE_USB FAILED
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ -d2.y, d2.x } / len
didn't compile for me either
{-d2.y, d2.x} * RECIPROCAL(len)
looked slower (1 divide, 2 multiplies instead of two divides)
so I used {-d2.y/len, d2.x/len}
The alternative of overloading /
for the xy_pos_t type was more than I wanted to tackle for this instance, as it would likely result in the same compiled code.
Casting was needed. |
Description
This fixes the problems from rounding error discussed in #14745
and an error introduced in the refactoring 56595a4
Related Issues
fixes #14745