Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compile error PID_LABEL and array bounds #15512

Closed
viper93458 opened this issue Oct 11, 2019 · 13 comments
Closed

[BUG] Compile error PID_LABEL and array bounds #15512

viper93458 opened this issue Oct 11, 2019 · 13 comments

Comments

@viper93458
Copy link

Description

Compile errors with current download for SKR Pro 1.1 and TMC2208
image

Steps to Reproduce

  1. Download current version from 8:30PM PST on 10/10/19
  2. Configure platformio.ini for SKR Pro 1.1
  3. Compile using my configs

Expected behavior: [What you expect to happen]
Successful compile

Actual behavior: [What actually happens]
Compile errors
image

Additional Information

Configs.zip

@boelle
Copy link
Contributor

boelle commented Oct 12, 2019

any clue what is wrong? maybe we can cook up a PR to fix it

@viper93458
Copy link
Author

Sadly no. Not being a developer, I could only report what's happening. :(

@Cova
Copy link

Cova commented Oct 13, 2019

I'm not sure what is wrong either - but having updated to the current code from a few months ago, I'm now getting this error as well. In my case on a SKR V1.3 with TMC2208 drivers.

Easy workaround for the time being is to disable PID_AUTOTUNE_MENU - that gets everything compiling and working properly, just have to use a serial terminal to run a PID autotune now instead of being able to do it from the LCD.

@tubl07
Copy link

tubl07 commented Oct 13, 2019

Also encountered this error using arduino ide 1.8.10 for mega2560 (RUMBA). Disabled menu PID_AUTOTUNE_MENU to compile successfully.

@viper93458
Copy link
Author

I tried and still got the array bounds error although the PID error went away.

-William

@viper93458
Copy link
Author

Disabling BABYSTEP_DISPLAY_TOTAL in Configuration_adv.h eliminates the array bounds error:

Previous:
#define BABYSTEP_DISPLAY_TOTAL

New:
//#define BABYSTEP_DISPLAY_TOTAL

-William

@boelle
Copy link
Contributor

boelle commented Oct 13, 2019

Also encountered this error using arduino ide 1.8.10 for mega2560 (RUMBA). Disabled menu PID_AUTOTUNE_MENU to compile successfully.

tried ide 1.9.0 beta?

@viper93458
Copy link
Author

Looks like the only issue left here is the babystep_display_total issue. Any thoughts on that piece?

-William

@boelle
Copy link
Contributor

boelle commented Oct 22, 2019

i think the PR merged 9 days ago has fixed the problem

please test again

@Cova
Copy link

Cova commented Oct 22, 2019

I'm running with PID_AUTOTUNE_MENU enabled again so it seems fixed to me.

@boelle
Copy link
Contributor

boelle commented Oct 22, 2019

oki will close this one then

we can always reopen

@boelle boelle closed this as completed Oct 22, 2019
@viper93458
Copy link
Author

Yes, I was able to compile with PID_AUTOTUNE_MENU enabled and babystep_display_total enabled. Thanks!

-William

@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants