Fix Temperature::over_autostart_threshold #16749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤦♂ |
tompe-proj
added a commit
to tompe-proj/Marlin
that referenced
this pull request
Feb 1, 2020
* Set up DIAG endstops for BTT SKR 1.4 / 1.4 Turbo (MarlinFirmware#16727) * Extend RX/TX pins for up to 8 extruders * Fix up, improve endstop pin auto-assignment Followup for MarlinFirmware#16723 * (21) PT100 for MCUs with 3.3v logic (MarlinFirmware#16731) * [cron] Bump distribution date (2020-01-31) * Add sanity-check for new Advanced Pause option Followup to MarlinFirmware#16372 * Include macros for delta ABC * Update Russian language (MarlinFirmware#16745) * Fix BTT SKR 1.4 extra endstop pins (MarlinFirmware#16738) * Option for Trigorilla 1.4 with add-on endstops board (MarlinFirmware#16737) * Consistent M112 with Emergency Parser (MarlinFirmware#16747) * Improve mfadd helper script - Use the original branch name if none is supplied - Set the remote tracking to the source - Accept User/Branch or User:Branch syntax * Clean up i2c encoder, sanitize serial * Misc cleanup, whitespace * Encapsulate probe as singleton class (MarlinFirmware#16751) * G34 automatic point assignment (MarlinFirmware#16473) * Fix Temperature::over_autostart_threshold (MarlinFirmware#16749) * Update Russian language (MarlinFirmware#16750) * Fix CURRENT_STEP_DOWN compile error * Drop obsolete SD special char handling See MarlinFirmware#14035 * Probe singleton patch Followup to MarlinFirmware#16751 * Fix RGB / Neopixel white color bug See MarlinFirmware#16752 Co-authored-by: Robert Stein <stonecoldcrazy@stoneathome.de> Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> Co-authored-by: Artur Petrzak <petrzmax@gmail.com> Co-authored-by: Acenotass <44540957+Acenotass@users.noreply.github.com> Co-authored-by: rebel1 <453277+rebel1@users.noreply.github.com> Co-authored-by: Jason Smith <jason.inet@gmail.com> Co-authored-by: InsanityAutomation <38436470+InsanityAutomation@users.noreply.github.com>
mjparme
added a commit
to mjparme/Marlin
that referenced
this pull request
Feb 1, 2020
* Don't test certain changes * Reset runout.ran_out on resume (MarlinFirmware#16230) * Step timing cleanup and rounding fix (MarlinFirmware#16258) * Add MRR_ESPA/_ESPE (ESP32) boards (MarlinFirmware#16238) * Add Ender-5 Pro config (MarlinFirmware#16221) * Add FLYBOARD (STM32F407ZG) (MarlinFirmware#16257) * Fix STM32 flush of TX (used by UBL) (MarlinFirmware#16197) * Flash leveling (for some STM32) (MarlinFirmware#16174) * Some ESP32 patches (MarlinFirmware#16297) * MKS SGen-L pins EEBF or EFBF scheme (MarlinFirmware#16296) * Add Rumba32 support for PIO (MarlinFirmware#16202) * MKS Robin 2 (STM32F407ZE) base support (MarlinFirmware#16270) * Update Czech language (MarlinFirmware#16305) * Sync SKR E3 configs (MarlinFirmware#16301) * Add NOZZLE_AS_PROBE (no probe offsets) (MarlinFirmware#15929) * Update README with status badge, etc. * Split up HAL items * Update mfpub for current MarlinDocumentation * Fix Max7219 with 256 or more cels * Fix games menu back item, titles * Update comments re: NOZZLE_AS_PROBE * Fix min limit for acc, feed, jerk (MarlinFirmware#16416) * Improve Renkforce configs (MarlinFirmware#16417) * Permit ENDSTOP_INTERRUPTS_FEATURE on more STM32 (MarlinFirmware#16412) * Improve STEVAL_3DP001V1 and future STEVAL_* support (MarlinFirmware#16404) * MKS Robin ILI9328 TFT support (MarlinFirmware#16401) * Disable PIDTEMPBED for SKR Mini E3 (MarlinFirmware#16396) * Return from loop() on non-AVR boards (MarlinFirmware#16390) * Refactor TMC-related macros and sanity checks (MarlinFirmware#16384) * Add FILAMENT_UNLOAD_PURGE_FEEDRATE (MarlinFirmware#16372) * Fix some DOGM warnings (MarlinFirmware#16363) * Fix warnings in stepper.cpp (MarlinFirmware#16364) * Fix PrintrBoard build (ignore TMC libraries) (MarlinFirmware#16346) (In future try to get Teensy processors better supported by `TMCStepper`.) * Clean up trailing whitespace * PWM pin not needed for Neopixel brightness / submenu (MarlinFirmware#16345) * Misc patches preceding DGUS PR * Fix Visual Micro "Arduino IDE for Visual Studio" support (MarlinFirmware#16418) * Update Russian language (MarlinFirmware#16426) * STM32F1: Fix misleading indent / nullptr on FSMC (MarlinFirmware#16431) * Z-offset edit precision based on value limits (MarlinFirmware#16425) * Add Ender-5 leadscrew README (MarlinFirmware#16424) * Add motherboard BIGTREE_SKR_V1.4_TURBO (MarlinFirmware#16374) * Enable MULTI_NOZZLE_DUPLICATION for BIBO (MarlinFirmware#16435) * Touch UI: Fix UBL mesh value editing (MarlinFirmware#16432) * Sidewinder X1 Config Updates (MarlinFirmware#16315) * Add Leapfrog Xeed 2015 support (MarlinFirmware#16400) * Improve JGAurora A1/A5S touch buttons (MarlinFirmware#16394) * Standardize drivers.h values, add class indirection (MarlinFirmware#16448) * Update Russian language (MarlinFirmware#16440) * BTT002: Add runout, PLR, and RGB pins (MarlinFirmware#16442) * Pins debugging AVR serial pins (MarlinFirmware#16437) * Fix MIN_PROBE_EDGE bug in default ABL G29 (MarlinFirmware#16367) * Temporary CI fix for STM32 * Use a default monitor_speed of 250000 * MSG_WATCH => MSG_INFO_SCREEN * Add EVNOVO (Artillery) Genius config (MarlinFirmware#16320) * Fixed Creality CR-20 Pro configuration example (MarlinFirmware#16332) * FYSETC F6 v1.4 board support (MarlinFirmware#16321) * Add example configs. Expand custom menu. (MarlinFirmware#16286) - Anet E10 - Geeetech D200 - Geeetech M201 - JGAurora Magic - MakerFarm Pegasus 12 * Fix Ender-2 display pins, add BTN_ENC (MarlinFirmware#16349) * Update and fix DGUS (MarlinFirmware#16317) * Fix serials available on SKR Pro 1.1 (MarlinFirmware#16439) * Fix daily date bump action * Action to check PRs * Update maintainer funding links * Skip build tests on forks * Update git helper usage * Fix EEPROM error with EXTRUDERS == 0 (MarlinFirmware#16464) * Fix M115 cap with EXTRUDERS == 0 (MarlinFirmware#16459) * Add option to invert joystick axes (MarlinFirmware#16466) * Update Russian language (MarlinFirmware#16461) * Fix permyriad progress bar (MarlinFirmware#16460) * Improve French language (UBL) (MarlinFirmware#16453) * Followup to EEPROM patch (MarlinFirmware#16470) * Remove extra UBL map edit menu item (MarlinFirmware#16451) * Fix unused var warning (MarlinFirmware#16467) * Update U20 config to help UBL toggle (MarlinFirmware#16471) * Move auto_build.py to 'vscode' folder * Fix MKS_SGEN sanity check (MarlinFirmware#16501) * Fix EEPROM array size bug (MarlinFirmware#16475) * Fix SKR Pro BLTouch conflicting timers (MarlinFirmware#16499) * Provide some missing Arduino macros (MarlinFirmware#16497) * Fix Change Filament menu item with runout (MarlinFirmware#16485) * Fix LCD for Tevo Tornado (MarlinFirmware#16474) * Update workflow skip condition * Add menu item Tune > Advance K (MarlinFirmware#16488) * Extend SERIAL_CHAR to take multiple arguments * Code style and comment tweaks * Correct ESP32 CPU speed in README (MarlinFirmware#16472) * Add ARC_SEGMENTS_PER_SEC for finer G2/G3 arcs (MarlinFirmware#16510) * Fix compile error w/out LCD (MarlinFirmware#16502) * Add Probe Offsets menu (MarlinFirmware#16444) * Fix Probe Offset XY edit items (et Français) (MarlinFirmware#16523) * Update Russian language (MarlinFirmware#16522) * [cron] Bump distribution date (2020-01-10) * Prevent Z misaligment on tool change (MarlinFirmware#16518) * Update Italian language (MarlinFirmware#16527) * ESP3d integration for ESP32 (MarlinFirmware#16515) * [cron] Bump distribution date (2020-01-11) * Migrate actions to default (2.0.x) branch * Only constrain motion on homed axes (MarlinFirmware#16533) Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> * Fix probeless delta build (MarlinFirmware#16537) * Use RECIPROCAL macro (not _RECIP) (MarlinFirmware#16530) * [cron] Bump distribution date (2020-01-12) * Restore test_builds action to bugfix * Update auto_build.py paths for Atom/Sublime * [cron] Bump distribution date (2020-01-13) * Add GTM32 (STM32F103VET6) environment (MarlinFirmware#16454) * Power options formatting * Geeetech G2Pro configuration (MarlinFirmware#16553) * Fix Linux upload path detection (MarlinFirmware#16514) * Add SERVO, TONE timers to variant for better STEVAL_3DP001V1 support (MarlinFirmware#16538) * Clean up whitespace * [cron] Bump distribution date (2020-01-14) * Improved STMicro L64XX stepper driver support (MarlinFirmware#16452) * Make lcd_power_loss_recovery_cancel exportable * Fix PLR cancel with ExtUI (MarlinFirmware#16556) * Bring MP_SCARA config up to date * Fix Fysetc S6 FLASH_PAGE_SIZE and test build (MarlinFirmware#16560) * [cron] Bump distribution date (2020-01-15) * Update more configs * Move configurations to a separate repo * Fix build error with unsupported reset flags (MarlinFirmware#16562) * Steval_3DP001V1 timers, analog inputs, etc. (MarlinFirmware#16565) * Use Flash EEPROM on BTT002 (MarlinFirmware#16558) * Get test configs from GitHub * Fix typo * Nikon IR support for time lapse photos (MarlinFirmware#16539) * Adjustable ADC debounce delay (MarlinFirmware#16264) * [cron] Bump distribution date (2020-01-16) * STM32 RODATA LENGTH (MarlinFirmware#16580) * Fix I2C address of MCP4728 on LPC176x (MarlinFirmware#16578) * Fix GTM32 environment (to prevent a crash) * Fix some warnings, Melzi pins * Move macros to stepper/indirection * Fix TOUCH_UI_FTDI_EVE bugs (MarlinFirmware#16540) * ESP32 HAL: Fix random pauses during prints (MarlinFirmware#16548) * [cron] Bump distribution date (2020-01-17) * STM32 soft SPI. STEVAL_3DP001V1 SD read. M906 tweaks. (MarlinFirmware#16579) * Clean up HAL ADC, old test scripts * Adjust GTM32 build flags (MarlinFirmware#16582) * Shared SPI sanity check (MarlinFirmware#16581) * More CI test updates * Update FYSETC S6 pins (MarlinFirmware#16559) * PINDA v2 temperature sensor / compensation (MarlinFirmware#16293) * [cron] Bump distribution date (2020-01-18) * Allow RRW Keypad with any LCD * [cron] Bump distribution date (2020-01-19) * [cron] Bump distribution date (2020-01-20) * Fix M112 with Emergency Parser * Simplify TMC monitor code * Updates for L64XX * Function-like macros * Use bool in pin compare * Patch for _STEP_INIT * Simplify a drivers.h macro (MarlinFirmware#16589) * SAMD51: ADC for probe temperature compensation (MarlinFirmware#16596) * Update FYSETC S6 Peripheral Pins (MarlinFirmware#16593) * Update BTT002 pins (MarlinFirmware#16591) * Reset shutdown timer on M85 (MarlinFirmware#16587) * AVR sanity check for MONITOR_DRIVER_STATUS with SW Serial (MarlinFirmware#16421) * STEVAL_3DP001V1: Easier Serial2 (for WIFI interface) (MarlinFirmware#16599) * Fix Greek language string (MarlinFirmware#16601) * Quad Z stepper support (MarlinFirmware#16277) * LPC1768: Allow I2C master channel override (MarlinFirmware#16584) * Move steps/mm out of slim menus (MarlinFirmware#16603) * Fix CHAMBER_MAXTEMP security margin (MarlinFirmware#16600) * L64xx M906 Fix status variable, formatting (MarlinFirmware#16597) * Provide methods for M420 + MBL (MarlinFirmware#16602) * [cron] Bump distribution date (2020-01-21) * Fix STM401/4xx/STM32F7xx timers, STEVAL_3DP001V1 warning (MarlinFirmware#16621) * Override for LPC1768 u8g/digipot I2C master ID (MarlinFirmware#16622) * Release UI on G26 priming timeout (MarlinFirmware#16449) * Add HMS434 V15 ATSAM board (MarlinFirmware#16620) * Tweak some config spacing * G12 defaults per tool. Event G-code for post-toolchange (MarlinFirmware#16554) * Arc segment radius scaling (MarlinFirmware#16551) * Update mfdoc, mfpub * [cron] Bump distribution date (2020-01-22) * Tweak mfpub stashing * [cron] Bump distribution date (2020-01-23) * Enable use of latest TMCStepper on MKS Robin Nano (MarlinFirmware#16652) * [cron] Bump distribution date (2020-01-24) * Convert chars only for enabled languages * Extra debugging for leveling on/off * Bring configs and drivers.h up to date * Duet Smart Effector support (MarlinFirmware#16641) * BigTreeTech GTR V1.0 / Support 8 extruders, heaters, temp sensors, fans (MarlinFirmware#16595) * [cron] Bump distribution date (2020-01-26) * Fix DELTA_CALIBRATION_MENU recursive call (MarlinFirmware#16656) * Fix MKS Base + Digipot compile error (MarlinFirmware#16636) * Add ESP3DLib idletask entry point (MarlinFirmware#16658) * Fix Serial defines for M43 on AVR (MarlinFirmware#16649) * Fix HOMING_BACKOFF_MM for DELTA (MarlinFirmware#16657) * Clean up PID language defines * More 8 extruder defines * Update Slovak language (MarlinFirmware#16646) * Fix M43 timer report on AVR (MarlinFirmware#16645) * Fix Spanish (swapped BLTouch strings) (MarlinFirmware#16637) * SKR 1.3 sensorless endstops hack (MarlinFirmware#16659) * Fix PID F menu label * [cron] Bump distribution date (2020-01-27) * Preserve CWD for write/remove file (MarlinFirmware#16667) * Rename some temperature members * Fix Trigorilla 1.4 limit switches See MarlinFirmware#16612 * Fix serial port redirection (index ≠ port num) (MarlinFirmware#16687) * G60/G61 Position Save/Restore (MarlinFirmware#16557) * Remove extraneous G60/G61 lines * Fix Manual Bed Leveling with multiple extruders (MarlinFirmware#16688) * [cron] Bump distribution date (2020-01-28) * Prevent SD access from resetting ESP32 (MarlinFirmware#16690) * [cron] Bump distribution date (2020-01-29) * Fix Toolchange (!no_move) return to status (MarlinFirmware#16699) * [cron] Bump distribution date (2020-01-30) * Cleanup of old includes, add comments * Fix HAS_FAN macro (MarlinFirmware#16717) * Fix probe temp calibration (MarlinFirmware#16718) * Support for E4d@BOX mainboard (MarlinFirmware#16716) * Fix missing string for M48 build (MarlinFirmware#16708) * Fix G60/G61 slots > 8 and compile error (MarlinFirmware#16715) * Move L64XX index_to_axis to progmem (MarlinFirmware#16697) * Refactor heater watch, job timer auto-start (MarlinFirmware#16725) * Auto assign DIAG pins for multi-endstop (MarlinFirmware#16723) * Tweak G60/G61 slots * Fix compile error in SdVolume on ESP32 (MarlinFirmware#16728) * Simultaneous use of rotary encoder and touch buttons (MarlinFirmware#16729) * Set up DIAG endstops for BTT SKR 1.4 / 1.4 Turbo (MarlinFirmware#16727) * Extend RX/TX pins for up to 8 extruders * Fix up, improve endstop pin auto-assignment Followup for MarlinFirmware#16723 * (21) PT100 for MCUs with 3.3v logic (MarlinFirmware#16731) * [cron] Bump distribution date (2020-01-31) * Add sanity-check for new Advanced Pause option Followup to MarlinFirmware#16372 * Include macros for delta ABC * Update Russian language (MarlinFirmware#16745) * Fix BTT SKR 1.4 extra endstop pins (MarlinFirmware#16738) * Option for Trigorilla 1.4 with add-on endstops board (MarlinFirmware#16737) * Consistent M112 with Emergency Parser (MarlinFirmware#16747) * Improve mfadd helper script - Use the original branch name if none is supplied - Set the remote tracking to the source - Accept User/Branch or User:Branch syntax * Clean up i2c encoder, sanitize serial * Misc cleanup, whitespace * Encapsulate probe as singleton class (MarlinFirmware#16751) * G34 automatic point assignment (MarlinFirmware#16473) * Fix Temperature::over_autostart_threshold (MarlinFirmware#16749) * Update Russian language (MarlinFirmware#16750) * Fix CURRENT_STEP_DOWN compile error * Drop obsolete SD special char handling See MarlinFirmware#14035 * Probe singleton patch Followup to MarlinFirmware#16751 * Fix RGB / Neopixel white color bug See MarlinFirmware#16752 * Suppress a compile warning * More 8-extruder fixups Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> Co-authored-by: Tanguy Pruvot <tpruvot@users.noreply.github.com> Co-authored-by: Jason Smith <jason.inet@gmail.com> Co-authored-by: Luc <8822552+luc-github@users.noreply.github.com> Co-authored-by: thisiskeithb <13375512+thisiskeithb@users.noreply.github.com> Co-authored-by: FLYmaker <49380822+FLYmaker@users.noreply.github.com> Co-authored-by: randellhodges <rhodges@taxfodder.com> Co-authored-by: ferengi82 <christian.maurer@gmx.eu> Co-authored-by: Luu Lac <45380455+shitcreek@users.noreply.github.com> Co-authored-by: petrzjunior <junior@zahradnik.cz> Co-authored-by: InsanityAutomation <38436470+InsanityAutomation@users.noreply.github.com> Co-authored-by: Giuliano Zaro <3684609+GMagician@users.noreply.github.com> Co-authored-by: Dirk O. Kaar <19971886+dok-net@users.noreply.github.com> Co-authored-by: Pascal de Bruijn <pmjdebruijn@pcode.nl> Co-authored-by: Bob Kuhn <bob.kuhn@att.net> Co-authored-by: Alexander Gavrilenko <jmz52@users.noreply.github.com> Co-authored-by: swilkens <stefanwilkens@gmail.com> Co-authored-by: Lino Barreca <linobarreca@hotmail.com> Co-authored-by: rado79 <51396577+rado79@users.noreply.github.com> Co-authored-by: Acenotass <44540957+Acenotass@users.noreply.github.com> Co-authored-by: ellensp <ellensp@hotmail.com> Co-authored-by: Walt Sorensen <photodude@users.noreply.github.com> Co-authored-by: yedey <myco@gmx.net> Co-authored-by: George Fu <nailao_5918@163.com> Co-authored-by: Vertabreaker <opyrus@hotmail.com> Co-authored-by: greppp <gregory.perrin87@gmail.com> Co-authored-by: Jamie <vector76@users.noreply.github.com> Co-authored-by: Justin <justinwilczek@gmail.com> Co-authored-by: ManuelMcLure <manuel@mclure.org> Co-authored-by: 0r31 <37673727+0r31@users.noreply.github.com> Co-authored-by: Alejandro Aguilera <fenixin@gmail.com> Co-authored-by: meponderR <33591888+meponderR@users.noreply.github.com> Co-authored-by: Mehdi Beyk Mohamadi <mbm_greenway@yahoo.com> Co-authored-by: FlyingSamson <59110786+FlyingSamson@users.noreply.github.com> Co-authored-by: Ryan V1 <55478432+V1EngineeringInc@users.noreply.github.com> Co-authored-by: David Klasinc <bigwhale@lubica.net> Co-authored-by: gjdodd <31553294+gjdodd@users.noreply.github.com> Co-authored-by: Dennis <16547088+soligen2010@users.noreply.github.com> Co-authored-by: felixstorm <felix.storm@glueckkanja.com> Co-authored-by: vivian-ng <vivian@maplerain.com> Co-authored-by: tompe-proj <59094873+tompe-proj@users.noreply.github.com> Co-authored-by: MaukCC <jos@mauk.cc> Co-authored-by: Ryan <allted@gmail.com> Co-authored-by: Artur Petrzak <petrzmax@gmail.com> Co-authored-by: yangwenxiong <46896566+yangwenxiong@users.noreply.github.com> Co-authored-by: Roman Moravčík <roman.moravcik@gmail.com> Co-authored-by: Robby Candra <robbycandra.mail@gmail.com> Co-authored-by: Hans007a <32525735+Hans007a@users.noreply.github.com> Co-authored-by: Neskik <axel.gouverneur@gmail.com> Co-authored-by: Mauro <exilaus@hotmail.com> Co-authored-by: Radek Pietruszewski <radexpl@gmail.com> Co-authored-by: chgi <chgi@users.noreply.github.com> Co-authored-by: Robert Stein <stonecoldcrazy@stoneathome.de> Co-authored-by: rebel1 <453277+rebel1@users.noreply.github.com>
squiddity
pushed a commit
to squiddity/Marlin
that referenced
this pull request
Feb 11, 2020
|
I was troubleshooting the same issue and also arrived to the same fix. Thanks @sjasonsmith for submitting the PR |
|
I also noticed that before 2.0.3 this termination gcode used work
but now I need to flip the order so Marlin can properly detect the end of the print:
I guess the reason for this is that the method GcodeSuite::M140() does not call thermalManager.check_timer_autostart. I can create a PR for this if desired |
|
@gdombiak, I’d say go ahead and post a PR. People probably won’t do anything based on comments stranded in this closed PR, so. If it’s easy you can just post a new one and get feedback from there. |
|
Done. #16842 :) |
StJa
added a commit
to StJa/Marlin
that referenced
this pull request
Mar 9, 2020
* Add sanity-check for new Advanced Pause option Followup to MarlinFirmware#16372 * Include macros for delta ABC * Update Russian language (MarlinFirmware#16745) * Fix BTT SKR 1.4 extra endstop pins (MarlinFirmware#16738) * Option for Trigorilla 1.4 with add-on endstops board (MarlinFirmware#16737) * Consistent M112 with Emergency Parser (MarlinFirmware#16747) * Improve mfadd helper script - Use the original branch name if none is supplied - Set the remote tracking to the source - Accept User/Branch or User:Branch syntax * Clean up i2c encoder, sanitize serial * Misc cleanup, whitespace * Encapsulate probe as singleton class (MarlinFirmware#16751) * G34 automatic point assignment (MarlinFirmware#16473) * Fix Temperature::over_autostart_threshold (MarlinFirmware#16749) * Update Russian language (MarlinFirmware#16750) * Fix CURRENT_STEP_DOWN compile error * Drop obsolete SD special char handling See MarlinFirmware#14035 * Probe singleton patch Followup to MarlinFirmware#16751 * Fix RGB / Neopixel white color bug See MarlinFirmware#16752 * Suppress a compile warning * More 8-extruder fixups * Add EXP labels to SKR pins * Fix LPC build with USE_WATCHDOG off * Minor string storage optimization * Apply REPEAT, RREPEAT, and loop macros (MarlinFirmware#16757) * Revert breaking change to _FAN_PWM macro * Add Z_AFTER_HOMING to raise Z more in G28 (MarlinFirmware#16755) * Corner Leveling: Add inset for each side (MarlinFirmware#16759) * (c) 2020 * Tweak mfqp script * Use a different Configurations branch for CI * Fix LCD Z Move character LCD display line (MarlinFirmware#16772) * Fix warning for ESP32 (MarlinFirmware#16771) * [cron] Bump distribution date * Force T0 in UBL G29 on all multi-hotend setups (MarlinFirmware#16774) * Keep secure credentials in a separate config file (MarlinFirmware#16773) * STM32duino - Use SDIO for onboard SD (MarlinFirmware#16756) * Fix E stepper stays on bug Fixes MarlinFirmware#16753 * Fix Arduino IDE compile for DUE Fixes MarlinFirmware#16767 * Fix CALIBRATION_GCODE pin handling * Upgrade an ifdef * More updates for 8 extruders, REPEAT * [cron] Bump distribution date (2020-02-05) * Add MKS Base 1.6 board (MarlinFirmware#16783) * Direct download link for configs * [cron] Bump distribution date (2020-02-06) * Split up MKS_RUMBA32 into two variants (MarlinFirmware#16781) * G26: Allow to set retraction for UBL mesh test (MarlinFirmware#16511) * Remove extraneous Serial init (MarlinFirmware#16794) * Fix probe with multi-endstops (MarlinFirmware#16793) * [cron] Bump distribution date (2020-02-07) * [cron] Bump distribution date (2020-02-08) * Clean up Makefle indentation * Add .editorconfig file * Tweak ABL logging, document probing * [cron] Bump distribution date (2020-02-09) * Coolstep for TMC2130, 2209, 5130, 5160 (MarlinFirmware#16790) * Better probe fail handling (MarlinFirmware#16811) * Adafruit Grand Central M4 fixes (MarlinFirmware#16812) * Minor HAL cleanup * Move MSG_MARLIN * Show print time with PRINTER_EVENT_LEDS * Tweak parser warning * Bump config version to 020004 (MarlinFirmware#16816) * Add PID, probe offsets to ExtUI (MarlinFirmware#16792) * [cron] Bump distribution date (2020-02-10) * Tweak LPC1768 upload py script * Add mftest -b (auto-build) and -u (upload) - Implement the equivalent of auto-build for the shell environment by using the MOTHERBOARD setting to look up the env: entries. * Revert change to AXIS_DRIVER_TYPE_X2 - Revisit this to figure out why it breaks * Revert "Coolstep for TMC2130, 2209, 5130, 5160" Reverting MarlinFirmware#16790 as not ready for primetime. * Add a caution to drivers.h * Update MKS BASE and v1.6 pins (MarlinFirmware#16806) * Add g-code quoted strings, improve stream code (MarlinFirmware#16818) * Fix out-of-order M0 after SD printing Fixes MarlinFirmware#14774 Co-Authored-By: tol2cj <tol2cj@users.noreply.github.com> * Fix out-of-order M0 after SD printing Fixes MarlinFirmware#14774 Co-Authored-By: tol2cj <tol2cj@users.noreply.github.com> * Enable hotend / bed PID separately in ExtUI (MarlinFirmware#16827) * Fix MKS Robin Nano platformio.ini entry (MarlinFirmware#16826) * Unify step pulse timing of ISR / babystep (MarlinFirmware#16813) * [cron] Bump distribution date (2020-02-11) * Update SAMD51 EEPROM repo link (MarlinFirmware#16832) * Undo driver type auto-assignment for now Good general concept but needs more time to develop and group with a stepper suite. * No Z sensorless req'd if homing with probe Fixes MarlinFirmware#16674 * Recommend Z Safe Homing Co-Authored-By: Vertabreaker <opyrus@hotmail.com> * Use prior babystep delay method (MarlinFirmware#16833) * Function-style critical section macros * Fix up tests * Simplify old safe homing sanity check * Prevent pin glitches on out commutation (MarlinFirmware#16835) Better for switching from pulled input to output and also set real output (with no input enabled). * [cron] Bump distribution date (2020-02-12) * Define MarlinSerial instances for DGUS (MarlinFirmware#16841) * No limit needed on this raise Remove an extraneous limit from MarlinFirmware#16811. * [cron] Bump distribution date (2020-02-13) * [cron] Bump distribution date (2020-02-14) * Fix G-code line parsing (MarlinFirmware#16840) * Ping the job timer in M140 (MarlinFirmware#16849) * Remove unused queue.stopped_N (MarlinFirmware#16850) * Don't assert safe homing for delta/scara * Fix ESP32 warning, specify supported version * Add ESPAsyncTCP to lib_ignore (MarlinFirmware#16844) * Add RAMPS 1.4.4 to AGCM4 (MarlinFirmware#16606) * Clean up host actions code (MarlinFirmware#16856) * Optimize "Dismiss" string * Clean up stepper and babystep (MarlinFirmware#16857) * Fysetc S6 pins / LCD updates (MarlinFirmware#16830) * [cron] Bump distribution date (2020-02-15) * Fix mftest -b and -u. Add --help. * Fix a BORG compile warning * Fix byte-to-percent display Fixes MarlinFirmware#16866 * Conceal float rounding errors on display Fix MarlinFirmware#16866 * [cron] Bump distribution date (2020-02-16) * Double ADC read frequency (MarlinFirmware#16864) * EXPERIMENTAL integrated BABYSTEPPING (MarlinFirmware#16829) * Show '*' for zero 'stst' flag * Require TMCStepper 0.6.2 * Defer updated ADC * Move SAMD51 Temperature timer to RTC (MarlinFirmware#16868) * Fix unknown command on empty lines (MarlinFirmware#16867) * Fix mftest -b -u line match * Update French language (MarlinFirmware#16877) * Put ESP32 I2S stepper task and Marlin on the same core (MarlinFirmware#16874) * Fix babystep include, typos in stepper.cpp Fix MarlinFirmware#16881 * [cron] Bump distribution date (2020-02-17) * [cron] Bump distribution date (2020-02-18) * [cron] Bump distribution date (2020-02-19) * [cron] Bump distribution date (2020-02-20) * Serial redirect for Move Command when stopping (MarlinFirmware#16906) * [cron] Bump distribution date (2020-02-21) * Single envs for specific boards * Inline manage_inactivity, tweak autoreport_paused * Function for CONFIG_ECHO_HEADING * Show end prompt with Print Event LEDs * Add a note on EEPROM todo * Tweak process_line_done for speed * More EEPROM cleanup * Followup to autoreport patch (MarlinFirmware#16914) See a1f026f * Disable spreadcycle in tmc_enable_stallguard<2209> (MarlinFirmware#16890) * Fix EEPROM errors with EXTRUDERS == 0 (MarlinFirmware#16898) * Add PICA shields support (MarlinFirmware#16891) * Tweak pins spacing, comments * Version 2.0.4 Release * [cron] Bump distribution date (2020-02-22) * Use moves_free in ok_to_send * Hotfix for Babystepping * CoreXY Babystepping hotfix * Use moves_free in ok_to_send * [cron] Bump distribution date (2020-02-22) * Hotfix for Babystepping * [ESP32] Allow user to define pins for hardware Serial1 and Serial2 (MarlinFirmware#16918) * CoreXY Babystepping hotfix * Version 2.0.4.1 Release * [cron] Bump distribution date (2020-02-23) * Finish Custom User Menu sanity-check (MarlinFirmware#16917) * Followup to babystep hotfix * Fix M0/M1 broken wait loop (MarlinFirmware#16921) * Define ANET_FULL_GRAPHICS_LCD pins for SKR 1.4 (MarlinFirmware#16928) * Version 2.0.4.2 Release * Suppress "packed member" warning * Suppress "packed member" warning * Commit last SD line before fileHasFinished * Allow LCD_PIXEL_WIDTH/HEIGHT override * Allow USE_GCODE_SUBCODES for debugging * Sync Italian language (MarlinFirmware#16935) * Reduce default TMC baudrate to 57600 with Software Serial (MarlinFirmware#16930) * [cron] Bump distribution date (2020-02-24) * Fix AXIS_HAS_SW_SERIAL * Simplified E_AXIS_HAS macro * "Init. Media" => "Attach Media" * Fix Babystepping loop (again) * BS_TOTAL_AXIS => BS_TOTAL_IND * Allow Z_SAFE_HOMING_POINT outside bed (MarlinFirmware#16945) * Restore tabs in Makefile (MarlinFirmware#16944) * Fix card_eof error * Version 2.0.4.3 Release * Allow Z_SAFE_HOMING_POINT outside bed (MarlinFirmware#16945) * Restore tabs in Makefile (MarlinFirmware#16944) * Fix card_eof error * [cron] Bump distribution date (2020-02-25) * Update POWER_LOSS_PIN comment (MarlinFirmware#16957) * Update Italian language (MarlinFirmware#16947) * Fix LCD cutter/bed icons overlapping (MarlinFirmware#16956) * Fix SKR 1.4 Turbo SD_DETECT_PIN (MarlinFirmware#16955) * Fix the wait loop in M0 / M1 * [cron] Bump distribution date (2020-02-26) * Ensure proper SD print completion (MarlinFirmware#16967) * HAS_SDCARD_CONNECTION is more obsolete * Fix GTR10 overlapping defines (MarlinFirmware#16976) * Toolchange improvements (MarlinFirmware#16979) * Language: "failsafe" => "Defaults" * Use a STR_ prefix for non-translated strings * Set LCD status for EEPROM errors (MarlinFirmware#16977) * More serial strings * Add LPC1768 Serial ports for pinsDebug (MarlinFirmware#16980) * Correct SKR expansion port pins (MarlinFirmware#16974) * String optimize followup * Fix Trinamic pulse rate auto-assignment (MarlinFirmware#16966) * Allow weird probe values in G33 * Serial strings in macros * Sanity check for LPC serial pin conflict (MarlinFirmware#16981) * Allow servo features in combination (MarlinFirmware#16960) * Add TRAVEL_EXTRA_XYJERK option See MarlinFirmware#16949 Co-Authored-By: josedpedroso <josedpedroso@users.noreply.github.com> * Quick-homing sensorless back-off (MarlinFirmware#16872) * Prevent park_point compile error * More extra travel jerk changes Co-Authored-By: josedpedroso <josedpedroso@users.noreply.github.com> * Fix unified status bed temp display * Allow print recovery after parking * Case-insensitive g-code option (MarlinFirmware#16932) * Define DIAG pins for MKS SGen-L * Handle print completed LED event in M0 * [cron] Bump distribution date (2020-02-27) * Fix planner.cpp compile (MarlinFirmware#16996) * Update Slovak language (MarlinFirmware#17002) * Version 2.0.4.4 Release Co-authored-by: Scott Lahteine <github@thinkyhead.com> Co-authored-by: Acenotass <44540957+Acenotass@users.noreply.github.com> Co-authored-by: rebel1 <453277+rebel1@users.noreply.github.com> Co-authored-by: Jason Smith <jason.inet@gmail.com> Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com> Co-authored-by: InsanityAutomation <38436470+InsanityAutomation@users.noreply.github.com> Co-authored-by: ellensp <ellensp@hotmail.com> Co-authored-by: felixstorm <felix.storm@glueckkanja.com> Co-authored-by: Bob Kuhn <bob.kuhn@att.net> Co-authored-by: thisiskeithb <13375512+thisiskeithb@users.noreply.github.com> Co-authored-by: Tanguy Pruvot <tpruvot@users.noreply.github.com> Co-authored-by: Robby Candra <robbycandra.mail@gmail.com> Co-authored-by: Robert Stein <robert.stein@requisis.com> Co-authored-by: Fabio Santos <fabiosan@live.com> Co-authored-by: Giuliano Zaro <3684609+GMagician@users.noreply.github.com> Co-authored-by: Daniel Mazurkiewicz <daniel@latanie.info> Co-authored-by: tol2cj <tol2cj@users.noreply.github.com> Co-authored-by: proferabg <proferabg@users.noreply.github.com> Co-authored-by: darksiah <siatam@gmail.com> Co-authored-by: Vertabreaker <opyrus@hotmail.com> Co-authored-by: Gaston Dombiak <gdombiak@gmail.com> Co-authored-by: vivian-ng <vivian@maplerain.com> Co-authored-by: George Fu <nailao_5918@163.com> Co-authored-by: Karl Andersson <karl@iaccess.se> Co-authored-by: Jamie <vector76@users.noreply.github.com> Co-authored-by: ZMiguel Alves <zmiguel@users.noreply.github.com> Co-authored-by: Marcio T <mlt4356-github@yahoo.com> Co-authored-by: josedpedroso <josedpedroso@users.noreply.github.com> Co-authored-by: Makoto Schoppert <makotosan@gmail.com> Co-authored-by: Roman Moravčík <roman.moravcik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Vertabreak told me that prints were not terminating properly at the end of a print job. The printer was remaining in print mode, with all the "active print" menu options available. I was able to easily reproduce this on my own printer.
This is a followup to #16725. The direction of one compare was backwards, resulting in the behavior.
Benefits
LCD reflects the printer is idle after a print, as expected.
Related Issues
I couldn't find an open issue, just @Vertabreak telling me about it.