Cleanup for FYSETC Cheetah #17935
Merged
Cleanup for FYSETC Cheetah #17935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
changed the title
sl1pkn07
added a commit
to sl1pkn07/Marlin
that referenced
this pull request
May 12, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
May 29, 2020
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
njibhu
pushed a commit
to njibhu/Marlin
that referenced
this pull request
Aug 24, 2020
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
EXTUI EVE touch LCD and Fysetc Cheetah board
Description
This is a cleanup of the pins_FYSETC_CHEETAH.h and pin_mappings.h files moving the EXTUI definitions over to pins_FYSETC_CHEETAH.h.
In addition the pins_FYSETC_CHEETAH.h is cleaned up overall.
Benefits
Clarity, simplicity.
The removal of the EXPA1_xx_PIN definitions that were not used outside of pins_FYSETC_CHEETAH.h make it simpler to look up to which pins of the controller functions are really assigned to.
Like that DOGLCD_CS or CLCD_SPI_CS is assigned to PB12.
A bunch of BTT_SKR pin definitions files use the EXPA1_xx_PIN defines as well and also only within these files which therefore serves no purpose.
But I can not test these.
Related Issues
The pins for BTN_EN1 and BTN_EN2 were swapped.