Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply extends to 8bit avr controllers #18118

Merged

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented May 26, 2020

Requirements

8bit avr controller

Description

Apply extends to 8bit avr's

Benefits

Reduces duplication in platformio.ini

Related Issues

None

@ellensp ellensp changed the title Apply exters to 8bit avr controllers Apply extends to 8bit avr controllers May 26, 2020
@ellensp
Copy link
Contributor Author

ellensp commented May 28, 2020

"extends = common_avr8" refers to non build-able section [common_avr8]
But "extends = env:melzi" refers to the build-able section [env:melzi] there is no section [melzi]
Same with "extends = env:at90usb1286_cdc
The env: is needed.
[env:common_LPC] is invalid. It should not have a env: as your not trying to build common_LPC
should be [common_LPC]

@thinkyhead
Copy link
Member

That is a distinction I hadn't noticed, thanks!

@thinkyhead thinkyhead merged commit a740b6b into MarlinFirmware:bugfix-2.0.x May 28, 2020
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request May 29, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
@ellensp ellensp deleted the bugfix-2.0.x-extens-8bit-avr branch June 29, 2020 14:09
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants