Fixes #16672 SDIO read errors #18223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_READ_RETRIES and SDIO_CLOCK, fixing SD Error problems on some user boards.
|
Is this intended to let us define sdio clock in the pins file if needed? |
|
Yes. With the changes here you will be able set your own |
thinkyhead
added
PR: Improvement
T: HAL & APIs
jmp0x0000
pushed a commit
to jmp0x0000/Marlin
that referenced
this pull request
Aug 7, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
HairingX
pushed a commit
to HairingX/Marlin
that referenced
this pull request
Jun 16, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some boards have problems with SDIO_CLOCK and READ Retries, getting SD Read Errors very frequently (Chitu boards, for example). The original code have hardcoded values.
Benefits
This PR just add the ability the user or the board define their on SDIO_CLOCK and READ Retries. Now Marlin can have board with different setups, yet maintaining the compatibility with the actual code.
We are using this in a future PR that will support the TronXY Chitu Boards.
Thanks.
Related Issues
#16672