-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend PTC options and fix probing bugs #18253
Conversation
Actually hold out on merging this, I would like to add linear extrapolation for temperatures below the start temperature. |
Does this retain compatibility with genuine PINDA V2 probes? I have a genuine MKS3s and another custom printer with a PINDA V2 I can test this on once the PR is ready for review. |
This doesn't really change much, except it may adjust the height that your probe heats up at. Arguably the old code that did this process did something, but most likely not what it intended so a change of behavior is arguably not wrong either. In fact now that I think about it, the old code might in cases produce a wrong starting temperature value / offset. The linear extrapolation might also change the behavior at lower temperatures if enabled (disabled by default). I also believe that the difference in probe behavior is probably more likely to be my aluminum heat bed rather than the probe itself. Though I do remember reading somewhere that the probes differ. I have added the linear extrapolation, and so I'm happy for this to be reviewed. |
It is however a design decision if it is better to have the reference point be the Z=0 offset w.r.t M851 or if it should be w.r.t the probe trigger point and I should not project |
Thanks @thinkyhead! @thisiskeithb happily still give it another test and if you have any issues just get back to me on this and I'll make sure they are patched ASAP. |
Requirements
This patch exposes some of the constants used by probe temperature calibration to the user and solves bugs described in #18227 .
Description
In the following code a bug was fixed where 2d point addition was performed to calculate
probe_pos_xyz
by castingmeasure_point
to an xyz value first. The0.5f
constant is exposed to the user. In additionprobe.offset_xy
is projected to 2D so thatPTC_PROBE_HEATING_OFFSET
is in reference to the Z coordinate frame, not the probe trigger point.The following fixes a bug where the probe wasn't stowed after each probe, stopping the printer from heating below the trigger point.
Benefits
Allows probing on non-genuine pinda v2 probes.
Related Issues
#18227