Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _common naming scheme for MKS Robin E3 & SKR Mini E3 boards #18354

Conversation

thisiskeithb
Copy link
Member

Description

Use *_common.h naming scheme for MKS Robin E3 & MKS Mini E3 boards.

Benefits

FIle names will be in line with other boards that share a *_common.h pins file and more importantly, de-dupe pins for the MKS Robin E3 (w/ integrated drivers) & E3D (w/ removable drivers) for easier editing since they share most of the same pin definitions.

Related Issues

None.

@thisiskeithb
Copy link
Member Author

thisiskeithb commented Jun 19, 2020

The Robin E3D *_CS_PIN pins could have been moved to the common pins using a #define MKS_ROBIN_E3D/#ifdef MKS_ROBIN_E3D trick like we did with the SKR Mini E3 V2 & common pins, but I wasn't sure if that would be too much clutter.

If it makes sense to group them with the other stepper pins, I'm happy to move them over to the common file and add a check. Something like:

//
// Steppers
//
#define X_STEP_PIN                          PC0
#define X_DIR_PIN                           PB2
#define X_ENABLE_PIN                        PC13
#ifdef MKS_ROBIN_E3D
  #ifndef X_CS_PIN
    #define X_CS_PIN                        PC7
  #endif
#endif

etc...

@thinkyhead
Copy link
Member

Only the E3D has the pins, so the way it is now is good.

@thinkyhead thinkyhead merged commit 8225d66 into MarlinFirmware:bugfix-2.0.x Jun 19, 2020
@thisiskeithb thisiskeithb deleted the pr/common_naming_scheme_MKS_BTT branch June 19, 2020 23:32
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants