Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: brian park gouache95@gmail.com
Requirements
CoreXY G28 Y is not working, so I fixed related bug.
Description
_CAN_HOME(Y) macro always return 0.
the reason is Y_MAX_PIN is 0, but _CAN_HOME macro check whether the pin is bigger than 0 or not.
0 is real pin number, not DISABLED.
I can check the variant.h in BIGTREE_SKR_PRO_1v1 like below.
~/.platformio/packages/framework-arduinoststm32/variants/BIGTREE_SKR_PRO_1v1/variant.h
#if STM32F4X_PIN_NUM >= 64 //64 pins mcu, 51 gpio
#define PC13 0
#define PC14 1 //OSC32_IN
#define PC15 2 //OSC32_OUT
.....
pins_BTT_GTR_V1.0.h is
so I change the comparison number to '-1' from '0'
Benefits
G28 and G28 Y works well
Related Issues
#18212