Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'No homing of y-axis' bug #18356

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

gouache
Copy link
Contributor

@gouache gouache commented Jun 19, 2020

Signed-off-by: brian park gouache95@gmail.com

Requirements

CoreXY G28 Y is not working, so I fixed related bug.

Description

_CAN_HOME(Y) macro always return 0.
the reason is Y_MAX_PIN is 0, but _CAN_HOME macro check whether the pin is bigger than 0 or not.

0 is real pin number, not DISABLED.
I can check the variant.h in BIGTREE_SKR_PRO_1v1 like below.

~/.platformio/packages/framework-arduinoststm32/variants/BIGTREE_SKR_PRO_1v1/variant.h
#if STM32F4X_PIN_NUM >= 64 //64 pins mcu, 51 gpio
#define PC13 0
#define PC14 1 //OSC32_IN
#define PC15 2 //OSC32_OUT
.....

pins_BTT_GTR_V1.0.h is

//
// Limit Switches
//
#define Y_MIN_PIN                           PG9
#define Y_MAX_PIN                           PC13

so I change the comparison number to '-1' from '0'

Benefits

G28 and G28 Y works well

Related Issues

#18212

Signed-off-by: brian park <gouache95@gmail.com>
@ellensp
Copy link
Contributor

ellensp commented Jun 19, 2020

got broken here https://github.com/MarlinFirmware/Marlin/pull/18150/files if your interested

@thinkyhead
Copy link
Member

thinkyhead commented Jun 19, 2020

Normally we also need to check defined(MY_PIN) because undefined macros evaluate to zero. But in this case, the endstop pins are guaranteed to exist (by pins.h) so your patch is fine. My previous patch was not mindful of this fact.

@thinkyhead thinkyhead merged commit bc9e5e2 into MarlinFirmware:bugfix-2.0.x Jun 19, 2020
@Minims
Copy link
Contributor

Minims commented Jun 22, 2020

Hi, i still have the issue with the very last commit. Compiled few minutes ago on bugfix. Is there a new issue ? Skr pro on core xy. Home x ok, home z ok, no home y

@gouache
Copy link
Contributor Author

gouache commented Jun 22, 2020

Hi, i still have the issue with the very last commit. Compiled few minutes ago on bugfix. Is there a new issue ? Skr pro on core xy. Home x ok, home z ok, no home y

could you share your Configuration.h & Configuration_adv.h files?

@Minims
Copy link
Contributor

Minims commented Jun 23, 2020

here it is : CoreXY-SKR-Pro.zip

@gouache
Copy link
Contributor Author

gouache commented Jun 23, 2020

here it is : CoreXY-SKR-Pro.zip

this patch is not for sensorless homing. please create new issue for your bug.

jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants