Change to arduino friendly include

[jeffeb3]

Requirements

• Filling out this template is required. Pull Requests without a clear description may be closed at the maintainers' discretion.

Description

The current bugfix branch doesn't build in arduino. The issue is some new tft code uses NULL, and to get the define, they included cstddef, which isn't available with arduino. The header stddef.h is available, and also works in platformio

Benefits

The builds once again will build in arduino, not just platformio.

[rhapsodyv]

By doesn't build in arduino, do you mean Arduino IDE? Or do you mean the AVR platform (like mega2560, etc)?

[jeffeb3]

Arduino IDE. But also the arduino cli.

I have automated builds for the ramps, rambo and mini rambo that also include using arduino to check that build.

I have also checked with arduino 1.8.13 in linux. The error is that it can't find cstddev, and there is also an error where arduino is trying to find the library named cstddev.

From some googling, it looks like cstddev has never been available (in Arduino).

[rhapsodyv]

But this new code is supposed to work only on STM32.
I would not be compiled when using a different platform.
🤔

[jeffeb3]

Well. I don't know how it is included. Is there something I can provide to help figure it out?

https://github.com/jeffeb3/MarlinBuilder/actions/runs/189986919

Those are my automated builds for ramps.

I have a seperate Marlin checked out on my computer from bugfix-2.0.x, I configured it for rambo and opened the arduino IDE. It fails in the same spot with the same error. If I jist change it to stddev.h, it compiles fine.

[rhapsodyv]

If you are using platformio, those files would be removed from build.
But, as you are using arduino ide, it will try to compile.

The better fix would be: surround all this new tft code with the #define it may need enabled for work.
But is not only this file. I think it’s all this folder.

[jeffeb3]

Well, FWIW, this one line change has made it build for me. At least in my desktop case.

I assume the other consequence of having it build might be a larger binary, right? So that will trickle into problems for things like melzi boards.

I am sure this question comes up frequently. Is arduino still a target build environment for platforms that support it? I have another issue open related to arduino builds. I'm not actually sure if it is still desired. I'm not sure where I would look for any official announcement of something like that.

[rhapsodyv]

Binary may not get any larger because GCC is clever and discard unused symbols. But the compile time will be higher.

I don't know if your correct breaks or not the original code.

My, in my option, its better to keep the original untouched and do what I suggested.

I can create a PR with what I'm suggesting.

[jeffeb3]

That makes sense to me.

I think this PR also makes sense though. stddef.h is included 15 times already, and this is the first time cstddef is included.

[rhapsodyv]

Let's @thinkyhead decide

[thinkyhead]

The pointy <stddef.h> include is better.

[Bulwark73]

I am attempting to set flash Marlin onto Mega2560 with Aduino 1.8.13 IDE. I am still getting fatal error: csddef:
Here is the whole error line;
Sketch\src\lcd\tft\tft_image.cpp:22:10: fatal error: cstddef: No such file or directory
#include "cstddef"

I downloaded the bugfix of Marlin 2.0x Yesterday morning @ 9am Chicago time.

What would I do to get Aduido IDE to stop giving me this error?

[thisiskeithb]

What would I do to get Aduido IDE to stop giving me this error?

Download a fresh copy of bugfix-2.0.x or manually edit Marlin/src/lcd/tft/tft_image.cpp as shown:

- #include "cstddef"
+ #include <stddef.h>

[Bulwark73]

YES. I wondered the same when I saw when thinkyhead had updated it. It is working now. All is good in the Nado verse now. ;) I appreciate this site and the information was easy to find. I am new to the site. Just getting use to where the times are listed. I must have downloaded my version just before he updated it. Oh well, Live and learn.