-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LVGL for Chitu after merges #18940
Merged
thinkyhead
merged 4 commits into
MarlinFirmware:bugfix-2.0.x
from
rhapsodyv:fixes-lvgl-chitu-post-merge
Aug 7, 2020
Merged
Fix LVGL for Chitu after merges #18940
thinkyhead
merged 4 commits into
MarlinFirmware:bugfix-2.0.x
from
rhapsodyv:fixes-lvgl-chitu-post-merge
Aug 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@thinkyhead This PR is all about the Try compiling with this config, you will see that it "runs" before the board is defined. (board chitu) |
And the CI is broken in bugfix because of |
Speaka
pushed a commit
to Speaka/Marlin
that referenced
this pull request
Aug 13, 2020
albertogg
pushed a commit
to albertogg/Marlin
that referenced
this pull request
Aug 31, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
ahmetcemturan
pushed a commit
to ahmetcemturan/Marlin
that referenced
this pull request
Jan 21, 2021
ahmetcemturan
added a commit
to ahmetcemturan/Marlin
that referenced
this pull request
Jan 23, 2021
This reverts commit c93e714.
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix some compilation issues when using chitu boards, after some merges. Particularly: the pic_manger.h needs to be the last header in the list, because it has some definitions that depends on the first headers.
Benefits
Make lvgl work again in chitu boards.
Related Issues