Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LVGL for Chitu after merges #18940

Merged

Conversation

rhapsodyv
Copy link
Sponsor Member

Description

This fix some compilation issues when using chitu boards, after some merges. Particularly: the pic_manger.h needs to be the last header in the list, because it has some definitions that depends on the first headers.

Benefits

Make lvgl work again in chitu boards.

Related Issues

@thinkyhead thinkyhead merged commit 35e11e5 into MarlinFirmware:bugfix-2.0.x Aug 7, 2020
@rhapsodyv
Copy link
Sponsor Member Author

@thinkyhead pic_manager.h needs to be the last header because it have a lot of #ifndef.

This PR is all about the pic_manager.h order.

Try compiling with this config, you will see that it "runs" before the board is defined. (board chitu)

Archive.zip

@rhapsodyv
Copy link
Sponsor Member Author

And the CI is broken in bugfix because of #include "../../../../inc/MarlinConfig.h" in pic_manager.h

Speaka pushed a commit to Speaka/Marlin that referenced this pull request Aug 13, 2020
albertogg pushed a commit to albertogg/Marlin that referenced this pull request Aug 31, 2020
@rhapsodyv rhapsodyv deleted the fixes-lvgl-chitu-post-merge branch October 25, 2020 00:28
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
ahmetcemturan pushed a commit to ahmetcemturan/Marlin that referenced this pull request Jan 21, 2021
ahmetcemturan added a commit to ahmetcemturan/Marlin that referenced this pull request Jan 23, 2021
kageurufu pushed a commit to CR30-Users/Marlin-CR30 that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants