Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Allow Two Adafruit MAX31865 boards to use Software SPI #19663

Closed
GadgetAngel opened this issue Oct 9, 2020 · 2 comments
Closed

[FR] Allow Two Adafruit MAX31865 boards to use Software SPI #19663

GadgetAngel opened this issue Oct 9, 2020 · 2 comments
Labels
T: Feature Request Features requested by users.

Comments

@GadgetAngel
Copy link
Contributor

GadgetAngel commented Oct 9, 2020

Description

I would like to see Marlin support two Adafruit MAX31865 boards that use Software SPI not hardware SPI. On a SKR PRO v1.1/v1.2 or GTR V1.0 board, there are a lot of free I/O PINS. It would be nice to use two (2) MAX31865 boards with Software SPI. Currently I can only manage to get ONE MAX31865 to use Software SPI.

Feature Workflow

Below in temperature.cpp the Adafruit_MAX31865 instance is called by passing:

MAX31865_CS_PIN,
MAX31865_MOSI_PIN,
MAX31865_MISO_PIN and
MAX31865_SCK_PIN

Can two MAX31865 board use Software SPI Question_All screens for Q_Page1

Here is the wiring diagram for two MAX31865 boards:

Can two MAX31865 board use Software SPI Question_All screens for Q_Page2

But, temperature.cpp, Marlin variable HEATER_1_USES_MAX6675, does not end
up calling max31865.temperature(100,430). It just does a return raw * 0.25

Also, I do not see where in temperature.cpp the Adafruit_MAX31865 instance is called by passing:

MAX31865_CS2_PIN,
MAX31865_MOSI_PIN,
MAX31865_MISO_PIN and
MAX31865_SCK_PIN.

NOTE: MAX31865_CS2_PIN does not get used. MAX6675_SS2_PIN gets used but to get the Adafruit MAX31865 call to use software SPI I am forced to ensure that MAX6675_SS_PIN is NOT equal to MAX31865_CS_PIN (see the very first picture).

Can two MAX31865 board use Software SPI Question_All screens for Q_Page3

I can get ONE MAX31865 board to work but NOT TWO MAX31865 boards.

I expected to see two boards to work.

On the GTR V1.0 board the default hardware SPI bus is the micro SD card reader, which makes accessing the default hardware SPI bus a lot harder.

It would be nice to have this all work with Software SPI.


Configuration files ONLY:

2MAX31865-configurationsFiles.zip


Whole Marlin folder .zip, including platformio.ini file on my google drive for you to download:

https://drive.google.com/file/d/1A8tHZmrHzKAHpVaGKLnOm6DDyTA9-g2x/view?usp=sharing

@GadgetAngel
Copy link
Contributor Author

This is can now be closed because the feature is now in bugfix-2.0.x branch!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

1 participant