Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Concept] TMC Sensorless Homing in M120/M121? #9742

Closed
thinkyhead opened this issue Feb 21, 2018 · 5 comments
Closed

[Concept] TMC Sensorless Homing in M120/M121? #9742

thinkyhead opened this issue Feb 21, 2018 · 5 comments
Labels
T: Design Concept Technical ideas about ways and methods. T: Development Makefiles, PlatformIO, Python scripts, etc.

Comments

@thinkyhead
Copy link
Member

thinkyhead commented Feb 21, 2018

The M120 and M121 commands don't currently support sensorless homing. Should s.h. be enabled and disabled by these commands too?

It would extend M120 and M121 to enable/disable of sensorless homing per-axis, while only the real endstops would be enabled/disabled using M120/M121 with no parameters.

The main use-case for M120/M121 is to enable endstops for the sake of the SD-abort-on-endstop-hit option. Outside of that it can be troublesome. If M120 is activated and a G1 move hits an endstop the current position becomes "unknown." Since we don't try to correct the position based on the steps count, this makes M120 slightly dangerous. It is feasible to recover the position from the stepper counts (and we could add another G-code to do that).

With sensorless homing it also becomes feasible to determine the position for any bump that stops the axis. But where and how to apply such a correction is not straightforward, especially for a print in progress. A position recovery re-home (as on Prusa MK3) makes the most sense.

@thinkyhead thinkyhead added T: Development Makefiles, PlatformIO, Python scripts, etc. T: Design Concept Technical ideas about ways and methods. labels Feb 21, 2018
@teemuatlut
Copy link
Member

The current implementation only enables the DIAG pin when homing and as far as Marlin knows, it's just a signal on a pin. So at the moment sensorless homing will not work with any abort on endstop hit feature.
But as we move to developing the skipped step detection and recovery system, we can no longer disable the DIAG pin outside of homing and so it makes sense to have gcodes that can enable/disable triggering.

@thinkyhead
Copy link
Member Author

I modified quick_home_xy to use sensorless homing too. I hope I got that right!

@boelle boelle mentioned this issue Jun 22, 2019
20 tasks
@boelle
Copy link
Contributor

boelle commented Oct 24, 2019

@thinkyhead still need this one?

@boelle
Copy link
Contributor

boelle commented Nov 24, 2019

this one has gone stale too and debate could move to discord

Marlin Discord server. Join link: https://discord.gg/n5NJ59y

@boelle boelle closed this as completed Nov 24, 2019
@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Design Concept Technical ideas about ways and methods. T: Development Makefiles, PlatformIO, Python scripts, etc.
Projects
None yet
Development

No branches or pull requests

3 participants