Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.x] Group #include <...> files, update header search paths #9763

Merged

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Feb 22, 2018

Reference: #8585

Update the -I arguments in lpc1768_flag_script.py and move certain LPC1768 headers into subfolders to simplify the include structure a bit.

@thinkyhead thinkyhead added T: HAL & APIs Topic related to the HAL and internal APIs. C: Build / Toolchain labels Feb 22, 2018
@teemuatlut
Copy link
Member

Ah yeah, the LPC HAL only worked because of this behavior where the compiler found the HAL/SPI.h file even when it probably shouldn't.
Solution could/would be to rename HAL_LPC1768/HAL_SPI.h -> HAL_LPC1768/SPI.h.

@thinkyhead
Copy link
Member Author

thinkyhead commented Feb 22, 2018

.piolibdeps/TMC2130Stepper_ID1493/src/source/TMC2130Stepper.cpp:3:10: fatal error: SPI.h: No such file or directory

Eek. I need to keep reminding myself: Spoofing the libraries into including our own SPI.h via <SPI.h> is necessary because we're doing whole substitution.

It's tough because I get can't get successful compiles due to other causes. I'm going to need a full primer on getting all platforms to compile from those in the know.

@thinkyhead thinkyhead force-pushed the bf2_random_fixup_branch branch 23 times, most recently from 9259ca8 to 67fab35 Compare February 23, 2018 01:53
@thinkyhead thinkyhead changed the title [2.0.x] Rename SPI.h to HAL_SPI.h [2.0.x] Group #include <...> files, update header search paths Feb 23, 2018
@thinkyhead thinkyhead merged commit 90fa423 into MarlinFirmware:bugfix-2.0.x Feb 23, 2018
@thinkyhead thinkyhead deleted the bf2_random_fixup_branch branch February 23, 2018 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Build / Toolchain T: HAL & APIs Topic related to the HAL and internal APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants