Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.x] Add 1284 support & misc. bug fixes #9864

Merged
merged 3 commits into from
Mar 1, 2018

Conversation

Bob-the-Kuhn
Copy link
Contributor

@Bob-the-Kuhn Bob-the-Kuhn commented Feb 28, 2018

This PR addresses the problems highlighted in Issue #9824.

PR #9869 is the bugfix-1.1.x version of this change.

The problems are:

  1. No 1284 support in PlatformIO - it just has 644 support.
  2. Analog channels were not displaying in the PINS_DEBUGGING command M43
  3. PINS_DEBUGGING was complaining about non-existent pins SDA and SCL.

File changes

  1. fastio_644.h - corrected pin mapping and added a graphic showing the pin mapping
  2. pinsDebug_AVR_8_bit.h - added 644/1284 version of macro IS_ANALOG(p)
  3. SanityCheck.h - removed check for E0_ENABLE_PIN for 644/1284 CPUs - only some of these have this pin
  4. pinsDebug_list.h - removed non-existent pins
  5. platformio.ini - added support for 1284P version of Sanguino
  6. HAL_pinsDebug_AVR.h - deleted it because it is not used.

1. fastio_644.h - corrected pin mapping and added a graphic showing the pin mapping

2. pinsDebug_AVR_8_bit.h - added 644/1284 version of macro IS_ANALOG9p)

3. SanityCheck.h - removed check for E0_ENABLE_PIN for 644/1284 CPUs - only some of these have this pin

4. pinsDebug_list.h - removed non-existent pins

5. platformio.ini - added support for 1284P version of Sanguino
Delete HAL_pinsDebug_AVR.h - it is not used.
@Bob-the-Kuhn Bob-the-Kuhn changed the title [2.0.x] DO NOT MERGE - Add 1284 support & misc. bug fixes [2.0.x] Add 1284 support & misc. bug fixes Mar 1, 2018
@Bob-the-Kuhn
Copy link
Contributor Author

Finally was able to compile with Arduino.

Arduino kept saying undefined reference to `main'. After trying 1.9.0(beta), 1.8.4, 1.8.5 and back to 1.9.0(beta) it compiled.

@thinkyhead
Copy link
Member

Arduino kept saying undefined reference to `main'.

Hmm. WTF?

@thinkyhead thinkyhead merged commit c1f4112 into MarlinFirmware:bugfix-2.0.x Mar 1, 2018
@Bob-the-Kuhn Bob-the-Kuhn deleted the 1284P-2.0.x branch March 1, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants