Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.x] First things first: Sort out SPI header spaghetti. #9931

Closed
thinkyhead opened this issue Mar 4, 2018 · 5 comments
Closed

[2.0.x] First things first: Sort out SPI header spaghetti. #9931

thinkyhead opened this issue Mar 4, 2018 · 5 comments
Labels
Needs: Discussion Discussion is needed T: Development Makefiles, PlatformIO, Python scripts, etc. T: HAL & APIs Topic related to the HAL and internal APIs.

Comments

@thinkyhead
Copy link
Member

thinkyhead commented Mar 4, 2018

@MarlinFirmware/32bit-maintainers !

At the moment the inter-dependency, most especially around the SPI-oriented headers in the HAL is distressing (BitOrder not defined, etc.). See #9476, etc. Let's figure out how to disentangle these –and any similar circular dependencies– so that we can move forward.

@thinkyhead thinkyhead added T: Development Makefiles, PlatformIO, Python scripts, etc. Needs: Discussion Discussion is needed T: HAL & APIs Topic related to the HAL and internal APIs. labels Mar 4, 2018
@teemuatlut
Copy link
Member

I think the clearest way is Marlin -> Possible library -> External SPI library -> Platform core.
Not everything can be included in Marlin since outside resources will not have access to the Marlin defined implementations.

BitOrder can be problematic since some define MSB/LSBFIRST as #define MSBFIRST and some use an enum of the two.

@thinkyhead
Copy link
Member Author

thinkyhead commented Mar 4, 2018

I mean, we can keep adding workarounds, like defining BitOrder in HAL_SPI.h differently for each platform. But ultimately, it just keeps digging us deeper.

@boelle boelle mentioned this issue Jun 22, 2019
20 tasks
@boelle
Copy link
Contributor

boelle commented Oct 24, 2019

@thinkyhead still working on this one?

@boelle
Copy link
Contributor

boelle commented Nov 24, 2019

this one has gone stale and discussion could as well be held on discord

Marlin Discord server. Join link: https://discord.gg/n5NJ59y

@boelle boelle closed this as completed Nov 24, 2019
@github-actions
Copy link

github-actions bot commented Jul 4, 2020

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: Discussion Discussion is needed T: Development Makefiles, PlatformIO, Python scripts, etc. T: HAL & APIs Topic related to the HAL and internal APIs.
Projects
None yet
Development

No branches or pull requests

3 participants