Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dot (.) as a thousand divider? #76

Closed
ferossan opened this issue Dec 31, 2021 · 4 comments
Closed

Add dot (.) as a thousand divider? #76

ferossan opened this issue Dec 31, 2021 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@ferossan
Copy link
Contributor

Some currency use dot as diveder for thousands, like $10.300,20 (ten thousand, three hundred and twenty cents). Is it possible to add it?

@Marmo Marmo added this to the 1.6.1 milestone Jan 2, 2022
@Marmo Marmo added the enhancement New feature or request label Jan 2, 2022
@Marmo
Copy link
Owner

Marmo commented Jan 2, 2022

Seems reasonable. I just don't record that big amounts usually, so I didn't miss the thousands separator.
This is a quick fix and I will include it in 1.6.1

@Marmo Marmo closed this as completed in 35b546f Jan 2, 2022
@ferossan
Copy link
Contributor Author

ferossan commented Jan 2, 2022

As a small contribution, I made the Spanish translation of your app. It may need some adjustments/corrections according to the context. Once it's included in the app, I will know for sure. Thanks.

@ferossan
Copy link
Contributor Author

ferossan commented Jan 5, 2022

Hello Marmo. Checked the Spanish translation in 1.6.1 and seems mostly fine. I made a couple corrections but in general looks pretty well. One thing I notice is the “Quick guide” that only appears in English (despite the rest it’s in Spanish).

In regard to the thousand separator, works fine if is used with 2 decimals (and maybe 1 and 3, didn’t try), but does not work fine with 0 decimals. For example, if having set previously decimals to 0, I lent 50.000 to some one and later I receive back 10.000 from the original, the 10.000 becomes a transaction of 1.000.000 on the Money list.

@Marmo
Copy link
Owner

Marmo commented Jan 6, 2022

Hm, thanks for reporting. That is really bad. Opened #79 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants