Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lines longer than 100 chars #283

Closed
wslulciuc opened this issue Feb 9, 2019 · 10 comments
Closed

Fix lines longer than 100 chars #283

wslulciuc opened this issue Feb 9, 2019 · 10 comments
Labels
cleanup good first issue Good for newcomers

Comments

@wslulciuc
Copy link
Member

$ ./gradlew checkstyleMain checkstyleTest

[ant:checkstyle] [WARN] /Users/willy.lulciuc/dev/marquezproject/marquez/src/test/java/marquez/api/JobIntegrationTest.java:300: Line is longer than 100 characters (found 196). [LineLength]
[ant:checkstyle] [WARN] /Users/willy.lulciuc/dev/marquezproject/marquez/src/test/java/marquez/db/NamespaceDaoTest.java:44: Line is longer than 100 characters (found 108). [LineLength]
...
@wslulciuc wslulciuc added good first issue Good for newcomers cleanup labels Feb 9, 2019
@wslulciuc wslulciuc mentioned this issue Feb 9, 2019
3 tasks
@hjpatel16
Copy link
Contributor

Hey, Can I work on it?

@wslulciuc
Copy link
Member Author

Sure! Thanks, @hjpatel16

@pbrahmbhatt3
Copy link
Contributor

can i work on it?

@wslulciuc
Copy link
Member Author

wslulciuc commented Mar 6, 2019

Hey, @pbrahmbhatt3. I believe @hjpatel16 wanted to tackle this issue. But, not sure of the progress. Would be great to get an update from @hjpatel16 before I reassigned the issue :)

@wslulciuc
Copy link
Member Author

@pbrahmbhatt3: Would you still like to work on this issue? Happy to reassign it to you.

@priyankalakhe
Copy link

@wslulciuc - I can work on this, if you are still looking for someone to take this up.

@wslulciuc
Copy link
Member Author

Yes! Thanks for your help, @priyankalakhe

@priyankalakhe
Copy link

Hi @wslulciuc - looks like this was deleted as part of 372013a

@wslulciuc
Copy link
Member Author

Yeah, the codebase has gone though some refactoring. Meaning, classes have been added or removed. If there aren’t any warnings around line length, we can close the issue.

@wslulciuc
Copy link
Member Author

@priyankalakhe, closing this issue for now. Thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants