Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize the use of '..DataSet..' to '..Dataset..' #350

Closed
roaraya8 opened this issue Feb 27, 2019 · 3 comments
Closed

Normalize the use of '..DataSet..' to '..Dataset..' #350

roaraya8 opened this issue Feb 27, 2019 · 3 comments
Labels
cleanup good first issue Good for newcomers

Comments

@roaraya8
Copy link
Contributor

In the code there are many variables referencing 'datasets' which are being written in both forms:

  • ...DataSet...'
  • '...Dataset..'

For cleanliness and consistency let's opt for one of them like '..Dataset..'
@ashulmanWeWork
Copy link
Contributor

For context, we decided on using Datasource.

@wslulciuc
Copy link
Member

@ashulmanWeWork : Mind creating an issue to normalize DataSource to Datasource?

@wslulciuc wslulciuc added good first issue Good for newcomers cleanup labels Feb 27, 2019
@ashulmanWeWork
Copy link
Contributor

Sure - filed #360.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wslulciuc @roaraya8 @ashulmanWeWork