Make DoUntil live up to its name #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My understanding of DoUntil is that it should keep doing the action every frame UNTIL some condition is true. This change makes DoUntil behave that way. Currently it seems to be a clone of DoWhenTask.
MartinIsla
approved these changes
Sep 5, 2020
|
Don't forget to hit the merge button. |
MartinIsla
added a commit
that referenced
this pull request
Sep 6, 2020
The behavior in DoUntilTask was actually right before. The task is executed until the condition is true. # Conflicts: # Assets/STasks/Scripts/Task Variants/DoUntilTask.cs
|
Sorry, I just realized the previous code was correct. The action is invoked until the condition is true. The task is completed (and terminated) once the condition is true. The proposed changes are more like a DoWhile, which doesn't exist yet, but it would be easy to implement. This, however, made me notice another issue. The action shouldn't be invoked in the Complete() method in STask. It's a leftover from the times where the only possible task was what's now called DoTask. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding of DoUntil is that it should keep doing the action every frame UNTIL some condition is true. This change makes DoUntil behave that way. Currently it seems to be a clone of DoWhenTask.