Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future updates to matrixStats may break your package tests #12

Closed
HenrikBengtsson opened this issue Mar 22, 2023 · 1 comment
Closed

Comments

@HenrikBengtsson
Copy link
Contributor

HenrikBengtsson commented Mar 22, 2023

Hi,

we're discussing updating matrixStats such that rowMedians() uses useNames = TRUE by default. When/if that happens, reverse-package dependency checks show that Canek will break (HenrikBengtsson/matrixStats#227). Specifically, it'll give:

─  checking tests ...
   Running the tests in ‘tests/testthat.R’ failed.
   Last 13 lines of output:
     > library(testthat)
     > library(Canek)
     > 
     > test_check("Canek")
     [ FAIL 1 | WARN 0 | SKIP 0 | PASS 89 ]
     
     ══ Failed tests ════════════════════════════════════════════════════════════════
     ── Failure ('test-Estimation.R:29:3'): Median Method ───────────────────────────
     y$`Correction Vector`[1] not equal to 0.00523153.
     names for target but not for current
     
     [ FAIL 1 | WARN 0 | SKIP 0 | PASS 89 ]
     Error: Test failures
     Execution halted

This can be fixed by relaxing that test to no consider the names attribute. I've created #11 to fix this - it's a very simply update.

It would be great if you could merge this for your next release. Thanks.

@ddiez
Copy link
Collaborator

ddiez commented Mar 23, 2023

Thank you @HenrikBengtsson for the news and the fix. PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants