Add meson build file #28

bioinfornatics · 2019-11-06T15:08:28Z

Dear,

In order to be able to build with meson. I added a meson.build file

$ meson build
$ ninja -C build
$ ninja install

meson.build

schveiguy · 2019-11-06T15:40:07Z

Also, we need to resolve this issue with the compiler and cas. Not sure what needs to happen there, it seems like a compiler bug.

bioinfornatics · 2019-11-06T21:08:38Z

Also, we need to resolve this issue with the compiler and cas. Not sure what needs to happen there, it seems like a compiler bug.

I think too is a compiler bug as I built with meson (and ldc2) the latest release with success.
Moreover here the build fail with dub

schveiguy · 2019-11-06T21:11:57Z

One final request, is there a way to ensure the meson build is tested during CI? Otherwise, you will be spending a lot of time fixing things when the meson build breaks ;)

bioinfornatics · 2019-11-06T21:12:53Z

One final request, is there a way to ensure the meson build is tested during CI?

I will take a look, I agree with you is better with test.

bioinfornatics · 2019-11-07T07:34:46Z

So I updated CI in order to add meson build part of test.
Moreover I extended both compiler compiler and os use to ldc and osx

Only meson with ldc build actually.
It is strange as I have do any change on dub and io source code.

Moreover currently the code is not dip1000 compatible as once I enable the feature meson with ldc fail.

bioinfornatics · 2019-11-07T10:50:55Z

I think too page deployment is broken from a long time as travis documentation tell to set the secret variable from the settings page of io repository and to use this code:

deploy:
  provider: pages
  skip_cleanup: true
  github_token: $GITHUB_TOKEN  # Set in the settings page of your repository, as a secure variable
  keep_history: true
  on:
    branch: master

To meet the travis documentation we have to

set the secrete variable
remove before_deploy section
update the deploy section accordingly to the documentation

dejlek · 2019-11-07T14:42:48Z

.appveyor.yml

-      $url = "http://downloads.dlang.org/releases/2.x/$($latest)/dmd.$($latest).windows.7z";
+      #$latest = (Invoke-WebRequest "http://downloads.dlang.org/releases/LATEST").toString();
+      #$url = "http://downloads.dlang.org/releases/2.x/$($latest)/dmd.$($latest).windows.7z";
+      $url = "http://downloads.dlang.org/releases/2.x/2.088.1/dmd.2.088.1.windows.7z"


Not sure you want this...

current io code can build up to dmdfe 2.088.1
Updating io code should be done in another pull request

Yeah, we can update this when the bugs are fixed in the latest compiler.

schveiguy · 2019-11-07T15:29:21Z

Looking at the meson build output, it doesn't look like it's running unittests. Is this expected? If it can run the unit tests, that would be ideal.

schveiguy · 2019-11-07T15:44:07Z

meson.build

+    link_args : common_ldflags,
+    install: true,
+    version: meson.project_version(),
+    d_unittest: false


Can we make a separate executable with unittests turned on?

From the meson site, looks like we can do that with:

io_test_exe = executable('io_test', sources, d_unittest: true) test('iotest', io_test_exe)

I think we would have to add a main function somewhere, and add that to the sources.

I added the option run_test

$ meson build -Drun_test=true $ ninja build test

Awesome! Let's see how it goes, and I'll merge if things look good. Thanks for all the effort here! Always good to spread libraries into alternate build mechanisms.

Thank you for your words of encouragement.
I think meson is a good thing for D libraries as the build system can to be used for linux distro packaging. Moreover it can generate pkg-config file and dub file. It can query dub repository and many others things :-)

Good stuff!

schveiguy · 2019-11-07T17:45:13Z

I think the meson test is failing because it's running the test application in the build directory, not in the root directory. Is there a way to fix it?

bioinfornatics · 2019-11-07T18:09:28Z

I think the meson test is failing because it's running the test application in the build directory, not in the root directory. Is there a way to fix it?

Thanks @schveiguy I will take a look

schveiguy · 2019-11-07T19:09:39Z

OK, I don't know how long it will be for LDC/DMD to get these bugs fixed. If you want to change the meson with ldc to not required, that's probably good enough for now, we can squash-merge.

schveiguy · 2019-11-07T20:55:57Z

@bioinfornatics I think we fixed the issue for LDC in #30. Can you add back in the ldc test with 1.18.0? I want to see if it works.

… fail

bioinfornatics · 2019-11-07T22:22:46Z

Good job that works 😉

schveiguy · 2019-11-07T23:12:38Z

Alright excellent! I think when ldc 1.19.0 comes out, we may have to revisit, but it's green right now. Thanks @kinke and @bioinfornatics.

schveiguy reviewed Nov 6, 2019

View reviewed changes

meson.build Outdated Show resolved Hide resolved

meson.build Show resolved Hide resolved

bioinfornatics changed the title ~~Add meson build file~~ WIP Add meson build file Nov 6, 2019

bioinfornatics force-pushed the meson_build_tool branch 6 times, most recently from 5210b3b to 2c55ec0 Compare November 7, 2019 07:28

bioinfornatics force-pushed the meson_build_tool branch 2 times, most recently from 3950754 to 2cae3c9 Compare November 7, 2019 09:29

bioinfornatics changed the title ~~WIP Add meson build file~~ Add meson build file Nov 7, 2019

bioinfornatics force-pushed the meson_build_tool branch 5 times, most recently from 477f26a to b668f5f Compare November 7, 2019 10:14

dejlek reviewed Nov 7, 2019

View reviewed changes

schveiguy reviewed Nov 7, 2019

View reviewed changes

bioinfornatics mentioned this pull request Nov 7, 2019

ldc 1.18.0 fail to run io unittest ldc-developers/ldc#3219

Closed

schveiguy mentioned this pull request Nov 7, 2019

std.io.driver.globalDriver(): Fix invalid reinterpret-cast #30

Merged

bioinfornatics added 17 commits November 7, 2019 23:05

Add meson build file

665bbf5

Fix project version

2f046f4

Remove deprecated bash test syntax

6dccb57

Add meson into CI

b0f9228

Update CI in order to test build with dub and meson

21cf181

Add d_unittest flag

d1685e1

Use meson from python repository

1ba7f54

Enable dip1000 feature

31ad96a

Move script to travis.sh

33f4568

Disable dip1000 feature

28a27a1

Add dmd 2.088.1 to CI

3979b5f

Use dmd 2.088.1

7d926b4

Remove unused and deprecated travis syntax

c01f5b3

Make dmd frontend 2.088.1 as required to build, others are allowed to…

033c86c

… fail

run unittest with meson

7988dd8

Add unitesting with meson into CI

bd359df

Copy LICENSE.txt into build dir in order to be foundable by unittest

c516be4

bioinfornatics force-pushed the meson_build_tool branch from 2a7278d to c516be4 Compare November 7, 2019 22:07

schveiguy merged commit 6b2974d into schveiguy:master Nov 7, 2019

bioinfornatics deleted the meson_build_tool branch November 8, 2019 07:32

bioinfornatics mentioned this pull request Nov 8, 2019

Github pages #31

Closed

schveiguy mentioned this pull request Feb 25, 2020

Appveyor should be updated to the latest version of DMD #37

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add meson build file #28

Add meson build file #28

bioinfornatics commented Nov 6, 2019

schveiguy commented Nov 6, 2019

bioinfornatics commented Nov 6, 2019 •

edited

schveiguy commented Nov 6, 2019 •

edited

bioinfornatics commented Nov 6, 2019 •

edited

bioinfornatics commented Nov 7, 2019 •

edited

bioinfornatics commented Nov 7, 2019 •

edited

dejlek Nov 7, 2019

bioinfornatics Nov 7, 2019 •

edited

schveiguy Nov 7, 2019

schveiguy commented Nov 7, 2019

schveiguy Nov 7, 2019 •

edited

schveiguy Nov 7, 2019

bioinfornatics Nov 7, 2019

schveiguy Nov 7, 2019

bioinfornatics Nov 7, 2019 •

edited

dejlek Nov 8, 2019

schveiguy commented Nov 7, 2019

bioinfornatics commented Nov 7, 2019

schveiguy commented Nov 7, 2019

schveiguy commented Nov 7, 2019

bioinfornatics commented Nov 7, 2019

schveiguy commented Nov 7, 2019

Add meson build file #28

Add meson build file #28

Conversation

bioinfornatics commented Nov 6, 2019

schveiguy commented Nov 6, 2019

bioinfornatics commented Nov 6, 2019 • edited

schveiguy commented Nov 6, 2019 • edited

bioinfornatics commented Nov 6, 2019 • edited

bioinfornatics commented Nov 7, 2019 • edited

bioinfornatics commented Nov 7, 2019 • edited

dejlek Nov 7, 2019

Choose a reason for hiding this comment

bioinfornatics Nov 7, 2019 • edited

Choose a reason for hiding this comment

schveiguy Nov 7, 2019

Choose a reason for hiding this comment

schveiguy commented Nov 7, 2019

schveiguy Nov 7, 2019 • edited

Choose a reason for hiding this comment

schveiguy Nov 7, 2019

Choose a reason for hiding this comment

bioinfornatics Nov 7, 2019

Choose a reason for hiding this comment

schveiguy Nov 7, 2019

Choose a reason for hiding this comment

bioinfornatics Nov 7, 2019 • edited

Choose a reason for hiding this comment

dejlek Nov 8, 2019

Choose a reason for hiding this comment

schveiguy commented Nov 7, 2019

bioinfornatics commented Nov 7, 2019

schveiguy commented Nov 7, 2019

schveiguy commented Nov 7, 2019

bioinfornatics commented Nov 7, 2019

schveiguy commented Nov 7, 2019

bioinfornatics commented Nov 6, 2019 •

edited

schveiguy commented Nov 6, 2019 •

edited

bioinfornatics commented Nov 6, 2019 •

edited

bioinfornatics commented Nov 7, 2019 •

edited

bioinfornatics commented Nov 7, 2019 •

edited

bioinfornatics Nov 7, 2019 •

edited

schveiguy Nov 7, 2019 •

edited

bioinfornatics Nov 7, 2019 •

edited