Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion regarding ordering of log and softmax in inference code #27

Open
umangksinha opened this issue Jun 23, 2020 · 0 comments
Open

Comments

@umangksinha
Copy link

umangksinha commented Jun 23, 2020

Hi Marvin,

Great project! I am trying to utilize it in my own research and went through your convcrf.py code. I have a doubt around this line where if I am not wrong, if default_conf["logsoftmax"] is True you take softmax followed by log using the log_softmax function (docs) but if it's False you take the log followed by the softmax. Can you please clarify on this?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant