hotfix(rate-limiting) properly use the selected Redis database #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thefosk can we add a more explicit comment either in the commit message or PR summary? Without context, this change is fairly subtle, and doesn't well highlight the nature of the bug (making PR review and future archaeology efforts challenging). |
p0pr0ck5
added
the
pr/changes requested
|
@p0pr0ck5 updated |
subnetmarco
added
pr/status/please review
and removed
pr/changes requested
p0pr0ck5
approved these changes
May 2, 2017
|
@p0pr0ck5 Changelog entries make rebasing and other git subtleties harder than necessary. better to to periodically update said changelog. Merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0) when retrieving counters if theconfig.policy=redis.