refactor(plugins) removing ngx.req.raw_header() for HTTP/2 compatibility #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
commented
May 17, 2017
spec/03-plugins/09-galileo/ngx.lua
Outdated
| return "GET /request/path HTTP/1.1\r\n".. | ||
| "Host: mockbin.com\r\n".. | ||
| "Accept: application/json\r\n".. | ||
| "Accept: application/x-www-form-urlencoded\r\n\r\n\r\n" |
There was a problem hiding this comment.
Required to avoid double escaping of \r.
This was referenced May 17, 2017
Closed
kong/plugins/galileo/alf.lua
Outdated
| size = size + #k + 2 + #tostring(y) + 2 --First 2 is semicolon + space | ||
| end | ||
| else | ||
| size = size + #k + 1 + 1 + #tostring(v) + 2 --First 2 is semicolon + space |
There was a problem hiding this comment.
why 1 + 1 instead 2? what makes it different from line 90?
kong/plugins/galileo/alf.lua
Outdated
| size = size + #k + 1 + 1 + #tostring(v) + 2 --First 2 is semicolon + space | ||
| end | ||
| end | ||
| return #request_line + 2 + size + 4 -- 2 it's \r\n, 4 it's trailing \r\n\r\n |
There was a problem hiding this comment.
I think you already counting one \r\n when you calculating the size of last header, so should't the final sum be like
#request_line + 2 + size + 2
shashiranjan84
added
pr/changes requested
subnetmarco
added
pr/status/please review
and removed
pr/changes requested
|
Updated. |
shashiranjan84
previously approved these changes
Jun 7, 2017
p0pr0ck5
force-pushed
the
refactor/raw-header
branch
from
f74dd07
to
9364f31
Compare
|
(fixed merge conflict and squashed) |
p0pr0ck5
approved these changes
Jun 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ngx.req.raw_header()invocation calls.