Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange naming in old records #96

Open
schymane opened this issue Sep 9, 2019 · 2 comments
Open

Strange naming in old records #96

schymane opened this issue Sep 9, 2019 · 2 comments

Comments

@schymane
Copy link
Member

schymane commented Sep 9, 2019

I'm not sure how this got through the validator but it doesn't look like these meet the Record Format requirements? @meier-rene can you look into this? Thanks!

image

Multiple names in the title field, including names that are clearly wrong (e.g. including the metal salt - sodium and lithium)

This was the query I ran:
https://massbank.eu/MassBank/Result.jsp?compound=&op1=and&mz=&tol=0.3&op2=and&formula=C4H6O3&type=quick&searchType=keyword&sortKey=not&sortAction=1&pageNo=1&exec=&inst_grp=ESI&inst=CE-ESI-TOF&inst=ESI-ITFT&inst=ESI-ITTOF&inst=ESI-QIT&inst=ESI-QTOF&inst=ESI-TOF&inst=LC-ESI-IT&inst=LC-ESI-ITFT&inst=LC-ESI-ITTOF&inst=LC-ESI-Q&inst=LC-ESI-QFT&inst=LC-ESI-QIT&inst=LC-ESI-QQ&inst=LC-ESI-QQQ&inst=LC-ESI-QTOF&inst=LC-ESI-TOF&ms=MS2&ion=0

@schymane
Copy link
Member Author

We have received the following feedback regarding this issue:
The dataset (PS... series), we produced 2008, have been rejected by Japan MassBank team due to poor data quality (sorry..).
We are very glad if you kindly remove such wrong data from NORMAN MassBank data repository.

@meier-rene @sneumann are you able to take care of this? Thanks!
Seems like a good case for deprecation?

@sneumann
Copy link
Member

So we need to deprecate these:
grep -l 10.1093/pcp/pcn183 MassBank-data/RIKEN_ReSpect/*

Just to confirm, this is about the 3604 records associated with the publication 10.1093/pcp/pcn183
marked as either "Build 4" or "Build 5", all measured on a Waters TQD.
Deprecation procedure was discussed in MassBank/MassBank-web#171 (comment)

Yours,
Steffen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants