Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR-1/PSR-2 #39

Closed
goetas opened this issue May 14, 2014 · 4 comments
Closed

PSR-1/PSR-2 #39

goetas opened this issue May 14, 2014 · 4 comments
Milestone

Comments

@goetas
Copy link
Member

goetas commented May 14, 2014

What about change the coding standard? (With the incoming 2.0 release?)

@mattfarina
Copy link
Member

I don't personally know that I have a preference here. Other projects I've worked on have recently switched to PSR-2 (e.g., OpenStack-SDK-PHP). A change like this can largely be automated using PHP-CS-Fixer.

@technosophos do you have any opinion?

@goetas
Copy link
Member Author

goetas commented May 16, 2014

Also i was thinking about PHP-CS-Fixer.

It is very boring have to change coding standard on IDE while switching between projects.

@technosophos
Copy link
Member

My feeling is that we should stay with what is considered best practice of the community at large. My sense is that PSR-2 has the momentum now (and works with composer), so we should go that way too. The 2.x release is a great chance to make that switch at a time when users will accept it.

@goetas
Copy link
Member Author

goetas commented May 30, 2014

PSR changes can be done when #37 is merged...

@goetas goetas added this to the 2.0 milestone Jun 10, 2014
@goetas goetas mentioned this issue Jun 11, 2014
@goetas goetas closed this as completed Jun 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants