Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for arm64 linux #311

Open
JoshAtticus opened this issue Nov 19, 2023 · 14 comments
Open

Build for arm64 linux #311

JoshAtticus opened this issue Nov 19, 2023 · 14 comments
Labels
Castlabs upstream issue Waiting for something to be fixed/added in our Castlabs dependency enhancement New feature or request

Comments

@JoshAtticus
Copy link

Would be nice to be able to run on arm64 linux without having to compile myself

@Mastermindzh Mastermindzh added the enhancement New feature or request label Nov 19, 2023
@Spl0itable
Copy link

Any movement on this? Thanks!

@andirsun
Copy link

andirsun commented Jan 2, 2024

I am opening a new update inside electron by castlabs with a solution for Widevine on arm64 platforms like Fedora Asahi for Apple M series macbooks castlabs/electron-releases#23 (comment)

@Mastermindzh
Copy link
Owner

Hey,

Yeah still waiting for Castlab to introduce ARM support eventually.
I mean, we can make an ARM build available if you want but it won't have widevine support I reckon.

I don't know if that's a problem since you're now building it yourself anyway.
Let me know.

@JoshAtticus
Copy link
Author

Hey,

Yeah still waiting for Castlab to introduce ARM support eventually. I mean, we can make an ARM build available if you want but it won't have widevine support I reckon.

I don't know if that's a problem since you're now building it yourself anyway. Let me know.

I initially made my issue related to M1 Macs with Asahi Linux. Asahi uses https://github.com/AsahiLinux/widevine-installer for Widevine and it might be possible to implement that and maybe even make it work on Raspberry Pis

@andirsun
Copy link

andirsun commented Jan 3, 2024

@Mastermindzh We could uses the asahi linux widevine installer for arm64 builds. I can test it if you want.

@Mastermindzh
Copy link
Owner

Sure, give it a whirl and let me know. I expect to work on a new version of Tidal Friday so we might be able to include this in the weekend :)

@Spl0itable
Copy link

Hey,

Yeah still waiting for Castlab to introduce ARM support eventually. I mean, we can make an ARM build available if you want but it won't have widevine support I reckon.

I don't know if that's a problem since you're now building it yourself anyway. Let me know.

Yes, I am using an ubuntu vm on m1 mac. I'd be happy to test without widevine support and see if there's any issues without the drm. Thanks!

@andirsun
Copy link

andirsun commented Jan 5, 2024

Well the app build properly but I am trying to add widevine support on Fedora for Macbooks.
I have support for widevine on Firefox and Chromium browsers as you can see here
Screenshot from 2024-01-04 22-54-15

The cdm is here
Screenshot from 2024-01-04 23-00-32

But after trying to make electron read the Widevine from path as recomended by Fedora mantainers
Screenshot from 2024-01-04 23-03-39

// * `widevinecdm.dll` on Windows.
try {
  app.commandLine.appendSwitch('widevine-cdm-path', '/usr/lib64/chromium-browser/WidevineCdm/_platform_specific/linux_arm64/libwidevinecdm.so')
  app.commandLine.appendSwitch('widevine-cdm-version', '4.10.2662.3')
  console.log(`Widevine CDM path: ${app.commandLine.getSwitchValue('widevine-cdm-path')}`)
} catch (error) {
  console.log(error)
}

Widevine is not being taken from proper directory.
Screenshot from 2024-01-04 22-55-03

I feel I am close to fix it but dont know how.

@Spl0itable
Copy link

@andirsun how did this go? Were you able to get an arm64 build working?

@andirsun
Copy link

@Spl0itable Actually no, I was not able to make electron read local Widevine CDM, so I ended creating a PWA shorcut using Chromium.
I think our best shot is to wait for castlabs to support arm64 officially.
Screenshot from 2024-01-10 12-55-20

@Spl0itable
Copy link

@andirsun Ah no, sorry to hear that. Wish it had worked. Thanks for trying.

@Mastermindzh
Copy link
Owner

Thanks for all the effort @andirsun.
Let's hope the ARM support issue/ticket is prioritized relatively quickly :)

@Mastermindzh Mastermindzh added the Castlabs upstream issue Waiting for something to be fixed/added in our Castlabs dependency label Jan 16, 2024
@cenunix
Copy link

cenunix commented Apr 7, 2024

so is this possible to use if I compile myself? or will i still be limited without widevine?

@andirsun
Copy link

andirsun commented Apr 7, 2024

@cenunix Yep you can compile the project by yourself but unless you are able to make electron read you widevine path to reproduce DRM protected content, the app will not play anything.

@andirsun andirsun removed their assignment Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Castlabs upstream issue Waiting for something to be fixed/added in our Castlabs dependency enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants