Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash at turn start when a frontline character falls #769

Closed
shadowfinted opened this issue Apr 27, 2018 · 26 comments
Closed

Crash at turn start when a frontline character falls #769

shadowfinted opened this issue Apr 27, 2018 · 26 comments

Comments

@shadowfinted
Copy link

Good day,

For the past few days zoi has been doing well until today. This has been happening often. It may be in the 1st battle or the 2nd one or the 3rd. Ive kept watch and it still happens and I can't seem to figure out why.

It usually happens towards the latter part of the raid.

image

@Ramkm77
Copy link

Ramkm77 commented Apr 27, 2018

Same here it's going fine until 1 char die and sub come in then crash so to avoid that I have to remove subs to work fine

@Nyyyx
Copy link

Nyyyx commented Apr 27, 2018

I'm experiencing the same problem as well.

@shadowfinted
Copy link
Author

Oh yeah lucio is a sub char but he's been coming out ever since before but it works fine until just today where zoi crashes.

@thebp2
Copy link

thebp2 commented Apr 27, 2018

Seems to happen to me when a sub comes in as well.

@JohnCog
Copy link

JohnCog commented Apr 27, 2018

Same

@inglixian
Copy link

inglixian commented Apr 27, 2018

I'm also getting a crash when trying to load map 3/3 with a subbed in character while farming white rabbit. Huge disappointment since I just purchased and it can't even finish the quest.

@JohnCog
Copy link

JohnCog commented Apr 27, 2018

Tried in 3 different computers with windows 7/8 and 10 , the same crash everytime

@Hexadecimalism
Copy link

Post your script.

@JohnCog
Copy link

JohnCog commented Apr 27, 2018

if character_4.charge_gauge >= 100 or character_3.charge_gauge >= 100 then
EnableChargeAttack()
else
DisableChargeAttack()
end
if character_2:HasStatusEffect(1111) and characters["Vane"].hp_percentage <= 20 and characters["Vane"].skill_3_available then
UseClarityHerbOnPartyMember(2)
Refresh()
end
if character_3:HasStatusEffect(1111) and characters["Vane"].hp_percentage <= 20 and characters["Vane"].skill_3_available then
UseClarityHerbOnPartyMember(3)
Refresh()
end
if character_4:HasStatusEffect(1111) and characters["Vane"].hp_percentage <= 20 and characters["Vane"].skill_3_available then
UseClarityHerbOnPartyMember(4)
Refresh()
end
if character_4.skill_2_available and characters["Diantha"].is_alive then
character_4:UseSkill(2)
end
if characters["Vane"].hp_percentage <= 20 and characters["Vane"].skill_3_available then
character_3:UseSkill(3)
Summon(1)
character_3:UseSkill(2)
character_2:UseSkill(1)
character_4:UseSkill(1)
character_4:UseSkill(3)
character_1:UseSkill(3)
character_3:UseSkill(1)
character_2:UseSkill(3)
end
if turn == 1 then
character_1:UseSkill(4)
character_2:UseSkill(2)
character_4:UseSkill(2)
character_3:UseSkill(2)
end
if turn == 4 and character_3.hp_percentage >= 41 and characters["Vane"].skill_3_available then
character_3:UseSkill(2)
Summon(1)
character_3:UseSkill(3)
character_2:UseSkill(1)
character_4:UseSkill(1)
character_4:UseSkill(3)
character_1:UseSkill(3)
character_3:UseSkill(1)
character_2:UseSkill(3)
else
end

@Hexadecimalism
Copy link

Hexadecimalism commented Apr 27, 2018

You're not doing a check for some characters being alive. If they are dead and the bot tries to use them, it crashes.

@JohnCog
Copy link

JohnCog commented Apr 27, 2018

So I should put ''if'characters["x"].is_alive'' before the start of a line? and what characters need check?

@Hexadecimalism
Copy link

Sure, I typically use

if characters["Tweyen"] ~= nil then
		characters["Tweyen"]:UseSkill(1)
		characters["Tweyen"]:UseSkill(2)
end

@sinanjugbf
Copy link

I thought nil was used for sub characters?
I've had:
if characters["Sandalphon"] ~= nil then
characters["Sandalphon"]:UseSkill(1)
characters["Sandalphon"]:UseSkill(3)
end

And it breaks zoibot everytime sandalphon comes out.

@Ohwhat00
Copy link

Yeah, issue started occurring after the update on granblue this morning. Zooey bot now crashes for me whenever I hit the 25% Trigger on GW Boss, which is when one of my characters dies and sub comes in.

@i-Grey
Copy link

i-Grey commented Apr 28, 2018

Happen with me too. Need help @Masuzu
Zooeybot crash when sub character came out. I think it has something relate to new update patch.

Edited after test something.
I think it happens when characters dies. I tried to use party with 4 people (including MC), bot still crash after someone dead.

@Masuzu
Copy link
Owner

Masuzu commented Apr 28, 2018

Hello,
I took note of the issue and this Viramate feature is now disabled by default in v2.12.3

@thebp2
Copy link

thebp2 commented Apr 28, 2018

Still crashing for me when a sub character comes out with 2.12.3 and EnableEarlyTurnStartWithViramate=false

@ZoiUser
Copy link

ZoiUser commented Apr 28, 2018

Yep still crashing even with 2.12.3
EnableEarlyTurnStartWithViramate=false

@IZEROII
Copy link

IZEROII commented Apr 28, 2018

I don't use viramate and the issue persists as soon as a sub comes into the front line.

@zooeyjapan
Copy link

yup, same here, crash since today when char comes in from backline and checking on the nil value for actions.

@zooeyjapan
Copy link

zooeyjapan commented Apr 28, 2018

Actually it crashes even when I removed any actions for my subs / nil value checks.
Simply, the moment a character dies, it crashes. As such it is important to figure this one out.
(as dokkan simply always dies :P )

@zooeyjapan
Copy link

zooeyjapan commented Apr 28, 2018

Tested without any subs and a basic mechanic lua script - if any char dies, it crashes.
(also tested with older version 2.11.12). @Masuzu this is currently game-breaking for any fights where 1 character might occasionally die. Something changed in GBF today.

@Masuzu
Copy link
Owner

Masuzu commented Apr 28, 2018

I see, thank you, something must have changed with the game then. I will check it using the trial battle mode. The good news is that so far I can reproduce the issue.

@Masuzu Masuzu changed the title Zooey bot stopped working Crash at turn start when a frontline character falls Apr 28, 2018
@Masuzu
Copy link
Owner

Masuzu commented Apr 28, 2018

A patch will be released within 15-30 minutes.

@Masuzu
Copy link
Owner

Masuzu commented Apr 28, 2018

This is now addressed in https://gbtools.azurewebsites.net/ZooeyBot/en/Home/PatchNotes#2-12-4

@Masuzu Masuzu closed this as completed Apr 28, 2018
@Masuzu Masuzu reopened this Apr 28, 2018
@zooeyjapan
Copy link

confirmed fixed, thanks a lot!

@Masuzu Masuzu closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests