Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Dial menu does not work on FF 84/85 #162

Closed
kasatikoff opened this issue Jan 8, 2021 · 5 comments
Closed

Quick Dial menu does not work on FF 84/85 #162

kasatikoff opened this issue Jan 8, 2021 · 5 comments

Comments

@kasatikoff
Copy link

Quick Dial menu does not work on FF 84/85

Menu block is empty and not hidden

FF-85_QD

@Shne
Copy link

Shne commented Jan 26, 2021

The reason for the breakage is that they have removed support for menuitem in Firefox 85: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/85#Removals_2
The reason is that it is deprecated and will be removed: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem
But for now it is hidden behind a flag: https://bugzilla.mozilla.org/show_bug.cgi?id=1680596 https://groups.google.com/g/mozilla.dev.platform/c/tc11BCenm2c?pli=1

So you can as a temporary measure re-enable it by setting the dom.menuitem.enabled flag to true in about:config.

In the longer run, this plugin should be updated to not use menuitem and related features, or its users will have to find an alternative.

@kasatikoff
Copy link
Author

Thank you, that solved the problem

@MatMoul
Copy link
Owner

MatMoul commented Jan 27, 2021

looking to fix it...
Give me some days...

@MatMoul
Copy link
Owner

MatMoul commented Jan 30, 2021

Hello,
You can try to force update your addons and reset dom.menuitem.enabled flag.
I've rewrited the context menu with the limitations of the current API.
Now all is grouped in the child menu "Quick Dial"

@ghost
Copy link

ghost commented Jan 30, 2021

Nice shot! Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants