Skip to content
This repository has been archived by the owner on Feb 3, 2021. It is now read-only.

Login may fail for passwords with symbols #11

Closed
Matchstic opened this issue May 1, 2017 · 3 comments
Closed

Login may fail for passwords with symbols #11

Matchstic opened this issue May 1, 2017 · 3 comments
Labels

Comments

@Matchstic
Copy link
Owner

Matchstic commented May 1, 2017

Some users are reporting passwords with the following symbols:

  • +

Do not authenticate when passed into saurik's backend system. Interestingly, they function as expected in my own authentication checks.

@Matchstic Matchstic added the bug label May 1, 2017
@Matchstic Matchstic changed the title User passwords with symbols may not be correctly URL encoded in saurik's backend User passwords with symbols may not be correctly URL encoded in my backend for signing in May 1, 2017
@Matchstic
Copy link
Owner Author

Matchstic commented May 5, 2017

Characters are now URL encoded, though since changing my password to test this is a tremendous pain due to all my devices that use my Apple ID, I will rely upon user reports for a measure of if this is fixed. Provided that I get no reports of this over the next 7 days, I will treat this as fixed.

Matchstic added a commit that referenced this issue May 5, 2017
@Matchstic Matchstic changed the title User passwords with symbols may not be correctly URL encoded in my backend for signing in Login may fail for passwords with symbols May 5, 2017
@Matchstic
Copy link
Owner Author

This also seems to be the case for usernames; commit 6b1f38f now encodes them too.

@Matchstic
Copy link
Owner Author

Commit b941e30 should now see the following symbols being handled correctly:

  • +
  • &
  • @
  • -

This has been unit tested to be working as expected now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant