This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
refactor: navigation, viewmodels and stores #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X1nto
changed the title
X1nto
changed the title
rushiiMachine
force-pushed
the
master
branch
from
31a27b4
to
71376e1
Compare
|
unnecessary anymore |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, stores rely on our custom Event class, which is very unreliable when new subscribers try to observe old data. Instead of creating events, this PR makes use of Room's Flow observables to provide the latest data. Alongside that, stores now sort the data before they're emitted to viewmodel, which decreases the UI overhead since compose now doesn't need to sort channels and guilds manually.