Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger OpenAPI validator yields an error #314

Closed
blokhin opened this issue Aug 11, 2020 · 8 comments · Fixed by #315
Closed

Swagger OpenAPI validator yields an error #314

blokhin opened this issue Aug 11, 2020 · 8 comments · Fixed by #315
Assignees
Labels
misc/question Further information is requested topic/validation Work on formal validation including implementations type/bug A bug or problem in the specification. Needs to be addressed quickly.

Comments

@blokhin
Copy link
Member

blokhin commented Aug 11, 2020

See https://validator.swagger.io/validator/debug?url=https://raw.githubusercontent.com/Materials-Consortia/OPTIMADE/develop/schemas/openapi_schema.json

Sorry if already known.

@blokhin blokhin added topic/validation Work on formal validation including implementations misc/question Further information is requested type/bug A bug or problem in the specification. Needs to be addressed quickly. labels Aug 11, 2020
@ml-evs
Copy link
Member

ml-evs commented Aug 12, 2020

Do you know why it might fail in your link (which contains "debug"), but seems to validate fine in the GUI version (unless I'm missing something)?

https://validator.swagger.io/?url=https://raw.githubusercontent.com/Materials-Consortia/OPTIMADE/master/schemas/openapi_schema.json

EDIT: looks like the GUI version is just for "exploring", so maybe we do have a problem...

@ml-evs
Copy link
Member

ml-evs commented Aug 31, 2020

Just a heads-up that we've fixed this upstream at Materials-Consortia/optimade-python-tools#480

(see e.g. https://validator.swagger.io/validator/debug?url=https://raw.githubusercontent.com/Materials-Consortia/optimade-python-tools/master/openapi/openapi.json).

We should prepare a PR for this repo fairly soon that updates the schema according to our changes since the 1.0 release.

@blokhin
Copy link
Member Author

blokhin commented Nov 29, 2020

@ml-evs Matthew, should the main schema be also PR-ed?

@blokhin blokhin reopened this Nov 29, 2020
@ml-evs
Copy link
Member

ml-evs commented Nov 29, 2020

These are all fixed on develop (and the schemas are now checked against this URL in the CI), and will be fixed on master when we decide to do a v1.0.1 release (or if we decide to reorganise our branches following #340).

https://validator.swagger.io/validator/debug?url=https%3A%2F%2Fraw.githubusercontent.com%2FMaterials-Consortia%2FOPTIMADE%2Fdevelop%2Fschemas%2Fopenapi_schema.json

@blokhin
Copy link
Member Author

blokhin commented May 5, 2021

@ml-evs is there any update on that?

PS my motivation is APIs-guru/openapi-directory#722

@ml-evs
Copy link
Member

ml-evs commented May 5, 2021

Hi @blokhin, the schemas have been fixed for a while now, we just haven't pushed to master as it is meant to be reserved for releases only. Once #351 is merged the link to master should work fine (still waiting on some reviews of blocking PRs; hopefully by the next workshop we will have 1.0.1...)

@ml-evs
Copy link
Member

ml-evs commented Jul 8, 2021

Closed by the v1.1 release (#365)!

@ml-evs ml-evs closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc/question Further information is requested topic/validation Work on formal validation including implementations type/bug A bug or problem in the specification. Needs to be addressed quickly.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants