Server validation incorrectly passes with various unimplemented features #1180
Labels
bug
Something isn't working
priority/high
Issue or PR with a consensus of high priority
validator
Related to the OPTIMADE validator
Just noticed that validation passes with some "lucky" choices of missing features, e.g.:
page_limit
(and silently ignores it), then the validator forresponse_fields
will pass (as there is a check is forlen(results) == page_limit
, notlen(results) > 0
)page_limit
and coincidentally uses the same defaultpage_limit
as the the validator, then it will pass the page limit testspage_offset
then it can get away with not supportingfilter
(!) as the same "random" structure is chosen for the archetypal filter validation.filter
at all, thus returning all results to all queries, all filter tests would pass as the validator treatedmore_data_available
as a sign that the filter was too large to be useful for testingThe text was updated successfully, but these errors were encountered: