Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server validation incorrectly passes with various unimplemented features #1180

Closed
ml-evs opened this issue May 21, 2022 · 0 comments · Fixed by #1181
Closed

Server validation incorrectly passes with various unimplemented features #1180

ml-evs opened this issue May 21, 2022 · 0 comments · Fixed by #1181
Assignees
Labels
bug Something isn't working priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator

Comments

@ml-evs
Copy link
Member

ml-evs commented May 21, 2022

Just noticed that validation passes with some "lucky" choices of missing features, e.g.:

  • If a server does not support page_limit (and silently ignores it), then the validator for response_fields will pass (as there is a check is for len(results) == page_limit, not len(results) > 0)
  • If a server does not support page_limit and coincidentally uses the same default page_limit as the the validator, then it will pass the page limit tests
  • If a server does not support page_offset then it can get away with not supporting filter (!) as the same "random" structure is chosen for the archetypal filter validation.
  • If a server does not support filter at all, thus returning all results to all queries, all filter tests would pass as the validator treated more_data_available as a sign that the filter was too large to be useful for testing
@ml-evs ml-evs added bug Something isn't working priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator labels May 21, 2022
@ml-evs ml-evs self-assigned this May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/high Issue or PR with a consensus of high priority validator Related to the OPTIMADE validator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant