New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable serving API under /v0.10 and /v0.10.0 by default? #122
Comments
For this, we may consider this section in the specification. From this, it seems we can remove the version base URLs. However, only clients are mentioned here, never really what a server SHOULD, MUST or MAY do/implement. Concerning your example:
This is taken care of in the spec, where it states that:
Personally, I like having them in this test server, to display how it may be done. |
Hm... you are right, perhaps we should ask for clarification on this? To be honest, section 3.1 on the base url seems over-engineered to me. The client already has the ability to ask which versions are available and under which URLs they are served (via the As for what to do by default in optimade-python-tools I stand by my point to not introduce additional endpoints unnecessarily, but let's perhaps wait until the spec is clarified on this point. |
I'll make a corresponding PR to the spec so that people can discuss this |
Note: This has been updated in the spec with PR Materials-Consortia/OPTIMADE#240. |
Indeed, and the new policy is: serve only under |
Currently, optimade-python-tools serves the same API under three separate base urls:
/optimade/
/optimade/vMAJ.MIN
/optimade/vMAJ.MIN.PAT
Besides bloating the openapi.json file and the corresponding swagger documentation, I would argue this also creates an expectation on the client side that the API will remain available under these base urls.
However - if I understand correctly - in the current implementation of the optimade-python-tools this is not foreseen. E.g. if we update the models for spec v0.10.1, then the
/optimade/v0.10.0
base url will be gone.To me this suggests that the default behavior of the server should be to serve only under
/optimade
, while making it easy for developers to replicate the API under additional base urls if they wish to do so.The text was updated successfully, but these errors were encountered: